gofmt issue fixes as per goreportcard (#1274)

[Bhargav-InfraCloud]

Signed-off-by: Bhargav Ravuri bhargav.ravuri@infracloud.io

Change Overview

• Fix the go formatting issues reported by goreportcardare.
• Add gofmt in golint.sh to warn for future commits.
• No functional or test logic changes made. This is only for go formatting.

Pull request type

Please check the type of change your PR introduces:

• 🌈 Refactoring (no functional changes, no api changes)

Issues

• fixes Fix linter issues per Go Report #1274

Test Plan

• 💪 Manual

1. Run make golint.
2. Install goreportcard and run goreportcard-cli -v. It should print stats similar to:

Grade .......... A+ 100.0%
Files .............. 31757
Issues ................. 0
gofmt ............... 100%
go_vet .............. 100%
ineffassign ......... 100%
gocyclo ............. 100%
license ............. 100%
misspell ............ 100%

Note: % of gofmt should be higher than what it was before this commit.

Message for maintainers

• golint is archived and so it was disabled from goreportcard in commit.
• Also, goreportcard uses gometalinter which is archived. The replacement is golangci-lint which is being used by Kanister already. However, most of the common linter in it (like, gofmt, revive, etc.) are not enabled or skipped for packages. I'd recommend to have a .golangci.yml configured to make most out of it.

---

[PrasadG193]

@Bhargav-InfraCloud If we add this, we don't need the previous call (Line no 25), right?

[Bhargav-InfraCloud]

It would require both, actually. The first one (line 25) runs 7 default linters (errcheck, gosimple, govet, ineffassign, staticcheck, typecheck & unused) with 4 enabled (maligned, whitespace, gocognit & unparam).

The second (line 32) only runs gofmt which is the core of this change.

Ideally, gofmt could've been added to the first. But in doing so, the extra conditions (skipping the directory and excluding ctx error) will get applied to this which is not wise. And also, gofmt without --build-tags integration would ignore 2 files dropping the % in report. Enable it in first directly and it would throw a lot of unexpected linter errors (not required as of now).

As I suggested in PR, using .golangci-yaml can solve this issue, where we can specify all the configs and run it only once. But that would be for future PR if agreed upon.

[PrasadG193]

Thanks @Bhargav-InfraCloud could you please file an issue to switch to .golanci-yaml

[Bhargav-InfraCloud]

Opened #1761

[pavannd1]

Thank you for the contribution @Bhargav-InfraCloud 🙏🏼
LGTM. Will let @PrasadG193 +2 this

[Bhargav-InfraCloud]

@pavannd1 @PrasadG193 The pipeline probably was failing because of commit e956100 or b48647f that I merged from master into this branch without checking the github action's status. I've now rebased with latest successful commit. Can you please trigger the pipeline again?

[Bhargav-InfraCloud]

Thanks again @PrasadG193 @pavannd1 😊