Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter issues per Go Report #1274

Closed
ihcsim opened this issue Mar 9, 2022 · 2 comments · Fixed by #1749
Closed

Fix linter issues per Go Report #1274

ihcsim opened this issue Mar 9, 2022 · 2 comments · Fixed by #1749
Labels
frozen good first issue help wanted
Projects
Kanister

Comments

@ihcsim
Copy link
Contributor

ihcsim commented Mar 9, 2022 •
edited

Go report is reporting many linter and formatting issues. We can use some help to clean them up. CI should also be updated to pick up these issues.
@shuguet shuguet added this to To do in Kanister Mar 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

This issue is marked as stale due to inactivity. Add a new comment to reactivate it.

@github-actions github-actions bot added the stale label May 9, 2022
@ihcsim
Copy link
Contributor Author

ihcsim commented May 10, 2022

Still relevant.

@ihcsim ihcsim added the frozen label May 10, 2022
@github-actions github-actions bot removed the stale label May 11, 2022
Bhargav-InfraCloud added a commit to Bhargav-InfraCloud/kanister that referenced this issue Nov 20, 2022
@Bhargav-InfraCloud
gofmt issue fixes as per goreportcard (kanisterio#1274)
24fdb11 
Go formatting issues as per github.com/gojp/goreportcard
are fixed and the linter 'gofmt' is enabled in golint.sh
for golangci-lint to warn for future commits

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Bhargav-InfraCloud added a commit to Bhargav-InfraCloud/kanister that referenced this issue Nov 20, 2022
@Bhargav-InfraCloud
gofmt issue fixes as per goreportcard (kanisterio#1274)
67b85d6 
Fix the go formatting issues reported by gojp/goreportcardare.
Add 'gofmt' in golint.sh to warn for future commits.

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
@Bhargav-InfraCloud Bhargav-InfraCloud mentioned this issue Nov 20, 2022
Merged
2 tasks
Bhargav-InfraCloud added a commit to Bhargav-InfraCloud/kanister that referenced this issue Nov 21, 2022
@Bhargav-InfraCloud
gofmt issue fixes as per goreportcard (kanisterio#1274)
5793775 
Fix the go formatting issues reported by gojp/goreportcardare.
Add 'gofmt' in golint.sh to warn for future commits.

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Bhargav-InfraCloud added a commit to Bhargav-InfraCloud/kanister that referenced this issue Nov 23, 2022
@Bhargav-InfraCloud
gofmt issue fixes as per goreportcard (kanisterio#1274)
faf37e5 
Fix the go formatting issues reported by gojp/goreportcardare.
Add 'gofmt' in golint.sh to warn for future commits.

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
@mergify mergify bot closed this as completed in #1749 Nov 29, 2022
mergify bot added a commit that referenced this issue Nov 29, 2022
@Bhargav-InfraCloud @mergify
gofmt issue fixes as per goreportcard (#1274) (#1749)
964a950 
Fix the go formatting issues reported by gojp/goreportcardare.
Add 'gofmt' in golint.sh to warn for future commits.

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Kanister automation moved this from Qualified Backlog to Done Nov 29, 2022
@Bhargav-InfraCloud Bhargav-InfraCloud mentioned this issue Feb 28, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frozen good first issue help wanted
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gofmt issue fixes as per goreportcard (#1274) Bhargav-InfraCloud/kanister
3 participants
@ihcsim @julio-lopez @pavannd1