Phase level progress tracking proposal #1875
Conversation
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
PrasadG193
changed the title
PrasadG193
changed the title
| Action can consists of multiple phases. These all phases can take consume different duration for completion based on the operations it performs. All phases for the action can be given equal weight-age and to calculate action progress completion %, average of all phase completion %ge can be calculated | ||
|
|
||
| ``` | ||
| % completion of action = sum(% Phase completion of all the phases)/ no. of phases |
There was a problem hiding this comment.
Are we not including the combined result as part of ActionStatus?
There was a problem hiding this comment.
We have ActionSetStatus.Progress and Phase level Progress, but not ActionStatus since use can only see actionset status. Is that the reason progress of each action is not included?
There was a problem hiding this comment.
Since ActionSet is supposed to perform single action only, the ActionSet progress is the same as Action progress. So by ActionSet.Progress users can get information about Action progress as well.
|
|
||
| ### Updating actionset status | ||
|
|
||
| [TrackActionProgress](https://github.com/kanisterio/kanister/blob/master/pkg/progress/action.go#L47) function is responsible for periodically updating progress for the action in ActionSet resource status. |
There was a problem hiding this comment.
How are we deciding the period for updating the progress?
There was a problem hiding this comment.
That would be const period - 5 or 10s
Co-authored-by: Ankit Jain <ankitjain.meone@gmail.com>
|
|
||
| ### Non-datamover Kanister functions | ||
|
|
||
| TBD |
There was a problem hiding this comment.
Even though it's not decided as of now, to actually implement this we will have to have something here right? For example either hard code or something else, otherwise would we be able to implement this design?
There was a problem hiding this comment.
Makes sense. We have discussed a couple of ideas, will add them here. Thanks
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
|
This PR is marked as stale due to inactivity. Add a new comment to reactivate it. |
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
Change Overview
Proposal for phase level progress tracking for actionset
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan