Add ExecutionProgress() method to function interface to report exec progress #2023

PrasadG193 · 2023-04-17T11:31:37Z

Change Overview

This PR adds ExecProgress() method to Kanister function interface to report the function exec progress.
This PR replaces the weight based progress calculation logic with function-specific implementation.
By default, all functions report progressPercent as 0 during exec and 100 once the execution is completed.
Ideally, each function should have a way to get stats of execution progress. Which can be added as a followup

The design has been discussed here: #1875

Pull request type

Please check the type of change your PR introduces:

Issues

fixes #issue-number

Test Plan

💪 Manual
⚡ Unit test
💚 E2E

Sample output of actionSet status of each phase completion status

TC:1 Blueprint action consists of 3 phases and all phases succeeds

1. First phase completed

status:
  actions:
  - artifacts:
      operatorBackup:
        keyValue:
          path: '{{ .Phases.phase3.Output.path }}'
    blueprint: operator-blueprint
    deferPhase:
      name: ""
      progress: {}
      state: ""
    name: backup
    object:
      apiVersion: ""
      group: ""
      kind: statefulset
      name: mysql
      namespace: mysql
      resource: ""
    phases:
    - name: phase1
      output:
        path: /operator-backups/2023-04-19T18-42-49/backup.tgz
      progress:
        lastTransitionTime: "2023-04-19T18:43:10Z"
        progressPercent: "100"
      state: complete
    - name: phase2
      progress: {}
      state: running
    - name: phase3
      progress: {}
      state: pending
  error:
    message: ""
  progress:
    lastTransitionTime: "2023-04-19T18:43:10Z"
    percentCompleted: "33"
    runningPhase: phase2
  state: running

2. Second phase completed

status:
  actions:
  - artifacts:
      operatorBackup:
        keyValue:
          path: '{{ .Phases.phase3.Output.path }}'
    blueprint: operator-blueprint
    deferPhase:
      name: ""
      progress: {}
      state: ""
    name: backup
    object:
      apiVersion: ""
      group: ""
      kind: statefulset
      name: mysql
      namespace: mysql
      resource: ""
    phases:
    - name: phase1
      output:
        path: /operator-backups/2023-04-19T18-42-49/backup.tgz
      progress:
        lastTransitionTime: "2023-04-19T18:43:10Z"
        progressPercent: "100"
      state: complete
    - name: phase2
      output:
        path: /operator-backups/2023-04-19T18-42-49/backup.tgz
      progress:
        lastTransitionTime: "2023-04-19T18:43:28Z"
        progressPercent: "100"
      state: complete
    - name: phase3
      progress: {}
      state: running
  error:
    message: ""
  progress:
    lastTransitionTime: "2023-04-19T18:43:28Z"
    percentCompleted: "66"
    runningPhase: phase3
  state: running

3. Third phase completed

status:
  actions:
  - artifacts:
      operatorBackup:
        keyValue:
          path: /operator-backups/2023-04-19T18-42-49/backup.tgz
    blueprint: operator-blueprint
    deferPhase:
      name: ""
      progress: {}
      state: ""
    name: backup
    object:
      apiVersion: ""
      group: ""
      kind: statefulset
      name: mysql
      namespace: mysql
      resource: ""
    phases:
    - name: phase1
      output:
        path: /operator-backups/2023-04-19T18-42-49/backup.tgz
      progress:
        lastTransitionTime: "2023-04-19T18:43:10Z"
        progressPercent: "100"
      state: complete
    - name: phase2
      output:
        path: /operator-backups/2023-04-19T18-42-49/backup.tgz
      progress:
        lastTransitionTime: "2023-04-19T18:43:28Z"
        progressPercent: "100"
      state: complete
    - name: phase3
      output:
        path: /operator-backups/2023-04-19T18-42-49/backup.tgz
      progress:
        lastTransitionTime: "2023-04-19T18:43:48Z"
        progressPercent: "100"
      state: complete
  error:
    message: ""
  progress:
    lastTransitionTime: "2023-04-19T18:43:48Z"
    percentCompleted: "100"
  state: complete

TC:2 Blueprint consists of 3 phases, first phases succeeds and 2nd one fails

1. First Phase started

status:                                                                                                                                               
  actions:                                                                                                                                            
  - artifacts:                                                                                                                                        
      operatorBackup:                                                                                                                                 
        keyValue:                                                                                                                                     
          path: '{{ .Phases.phase3.Output.path }}'                                                                                                    
    blueprint: operator-blueprint                                                                                                                     
    deferPhase:                                                                                                                                       
      name: ""                                                             
      progress: {}                                                                                                                                    
      state: ""                                                            
    name: backup                                                                                                                                      
    object:                                                                
      apiVersion: v1                                                                                                                                  
      group: apps                                                          
      kind: statefulset                                                                                                                               
      name: mysql                                                          
      namespace: mysql                                                                                                                                
      resource: statefulsets                                                                                                                          
    phases:                                                                                                                                           
    - name: phase1                                                                                                                                    
      progress: {}                                                                                                                                    
      state: running                                                                                                                                  
    - name: phase2                                                                                                                                    
      progress: {}                                                                                                                                    
      state: pending                                                                                                                                  
    - name: phase3                                                                                                                                    
      progress: {}                                                                                                                                    
      state: pending                                                       
  error:                                                                                                                                              
    message: ""                                                            
  progress:                                                                                                                                           
    runningPhase: phase1                                                   
  state: running

2. First phase completed and Second phase started

status:                                                                                                                                               
  actions:                                                                                                                                            
  - artifacts:                                                                                                                                        
      operatorBackup:                                                                                                                                 
        keyValue:                                                                                                                                     
          path: '{{ .Phases.phase3.Output.path }}'                                                                                                    
    blueprint: operator-blueprint                                                                                                                     
    deferPhase:                                                                                                                                       
      name: ""                                                             
      progress: {}                                                                                                                                    
      state: ""                                                            
    name: backup                                                                                                                                      
    object:                                                                
      apiVersion: v1                                                                                                                                  
      group: apps                                                          
      kind: statefulset                                                                                                                               
      name: mysql                                                          
      namespace: mysql                                                                                                                                
      resource: statefulsets                                                                                                                          
    phases:                                                                                                                                           
    - name: phase1                                                                                                                                    
      progress: {}                                                                                                                                    
      state: running                                                                                                                                  
    - name: phase2                                                                                                                                    
      progress: {}                                                                                                                                    
      state: pending                                                                                                                                  
    - name: phase3                                                                                                                                    
      progress: {}                                                                                                                                    
      state: pending                                                       
  error:                                                                                                                                              
    message: ""                                                            
  progress:                                                                                                                                           
    runningPhase: phase1                                                   
  state: running

3. Second phase failed

status:                                                                                                                                                                                                     
  actions:                                                                                                                                                                                                            
  - artifacts:                                                                                                                                                                                                        
      operatorBackup:                                                                                                                                                                                                 
        keyValue:                                                                                                                                                                                                     
          path: '{{ .Phases.phase3.Output.path }}'                                                                                                                                                                    
    blueprint: operator-blueprint                                                                                                                                                                                     
    deferPhase:                                                                                                                                                                                                       
      name: ""                                                                                                                                                                                                        
      progress: {}                                                                                                                                                                                                    
      state: ""                                                                                                                                                                                                       
    name: backup                                                                                                                                                                                                      
    object:                                                                                                                                                                                                           
      apiVersion: v1                                                                                                                                                                                                  
      group: apps                                                                                                                                                                                                     
      kind: statefulset                                                                                                                                                                                               
      name: mysql                                                                                                                                                                                                     
      namespace: mysql                                                                                                                                                                                                
      resource: statefulsets                                                                                                                                                                                          
    phases:                                                                                                                                                                                                           
    - name: phase1                                                                                                                                                                                                    
      output:                                                                                                                                                                                                         
        path: /operator-backups/2023-05-22T07-32-36/backup.tgz                                                                                                                                                        
      progress:                                                                                                                                                                                                       
        lastTransitionTime: "2023-05-22T07:32:54Z"                                                                                                                                                                    
        progressPercent: "100"                                                                                                                                                                                         
      state: complete                                                                                                                                                                                                 
    - name: phase2                                                                                                                                                                                                    
      progress: {}                                                                                                                                                                                                    
      state: failed                                                                                                                                                                                                   
    - name: phase3                                                                                                                                                                                                    
      progress: {}                                                                                                                                                                                                    
      state: pending                                                                                                                                                                                                  
  error:                                                                                                                                                                                                              
    message: "Failed while waiting for Pod kanister-job-sk2bk to complete: Pod failed                                                                                                                                 
      or did not transition into complete state: Running backup\
     .
     .
  progress:                                                                                                                                                             
    lastTransitionTime: "2023-05-22T07:32:54Z"                                          
    percentCompleted: "33"                                                           
  state: failed

TC:3 Blueprint with actions having multiple phases. And actionset running multiple action

1. First phase if each action is running

status:       
  actions:        
  - artifacts: 
      operatorBackup:
        keyValue:
          path: '{{ .Phases.backupPhase3.Output.path }}'
    blueprint: operator-blueprint
    deferPhase:        
      name: ""   
      progress: {}    
      state: ""   
    name: backup
    object:              
      apiVersion: ""
      group: ""     
      kind: statefulset  
      name: mysql 
      namespace: mysql
      resource: ""       
    phases:       
    - name: backupPhase1
      progress:
        lastTransitionTime: "2023-08-11T06:41:08Z"
        progressPercent: "0"
      state: running           
    - name: backupPhase2
      progress: {}
      state: pending               
    - name: backupPhase3
      progress: {}
      state: pending                             
  - blueprint: operator-blueprint                 
    deferPhase:                                    
      name: ""                                     
      progress: {}                                   
      state: ""                                       
    name: restore                                      
    object:                                              
      apiVersion: ""                                      
      group: ""                                           
      kind: statefulset                                   
      name: mysql                                         
      namespace: mysql                                    
      resource: ""                                        
    phases:                                               
    - name: restorePhase1                                 
      progress: {}                                        
      state: running                                      
    - name: restorePhase2                                 
      progress: {}                                        
      state: pending                                      
    - name: restorePhase3                                 
      progress: {}                                        
      state: pending                                      
  error:                                                  
    message: ""                                           
  progress:                                               
    lastTransitionTime: "2023-08-11T06:41:08Z"            
    percentCompleted: "0"                                 
    runningPhase: restorePhase1                           
  state: running

2. First phase of second action is completed

status:                                                                                                                                                                                                                                 
  actions:                                                
  - artifacts:                                            
      operatorBackup:                                     
        keyValue:                                         
          path: '{{ .Phases.backupPhase3.Output.path }}'                                                            
    blueprint: operator-blueprint                         
    deferPhase:                                           
      name: ""                                            
      progress: {}                                        
      state: ""                                           
    name: backup                                          
    object:                                               
      apiVersion: ""                                      
      group: ""                                           
      kind: statefulset                                   
      name: mysql                                         
      namespace: mysql                                    
      resource: ""                                        
    phases:                                               
    - name: backupPhase1                                  
      progress:                                           
        lastTransitionTime: "2023-08-11T06:41:08Z"                                                                  
        progressPercent: "0"                              
      state: running                                      
    - name: backupPhase2                                  
      progress: {}                                        
      state: pending                                      
    - name: backupPhase3                                  
      progress: {}                                        
      state: pending                                      
  - blueprint: operator-blueprint                         
    deferPhase:                                           
      name: ""                                            
      progress: {}                                        
      state: ""                                           
    name: restore                                         
    object:                                               
      apiVersion: ""                                      
      group: ""                                           
      kind: statefulset                                   
      name: mysql                                         
      namespace: mysql                                    
      resource: ""                                        
    phases:                                               
    - name: restorePhase1                                 
      progress:                                           
        lastTransitionTime: "2023-08-11T06:41:18Z"                                                                  
        progressPercent: "100"                            
      state: complete                                     
    - name: restorePhase2                                 
      progress: {}                                        
      state: pending                                      
    - name: restorePhase3                                 
      progress: {}                                        
      state: pending                                      
  error:                                                  
    message: ""                                           
  progress:                                               
    lastTransitionTime: "2023-08-11T06:41:18Z"            
    percentCompleted: "16"                                
    runningPhase: restorePhase1                           
  state: running

3. First phase of both the action is completed and 2nd phase is running

status:                                                                                                                                                                                                                                 
  actions:                                                                                                                                                                                                                              
  - artifacts:                                                                                                                                                                                                                          
      operatorBackup:                                                                                                                                                                                                                   
        keyValue:                                                                                                                                                                                                                       
          path: '{{ .Phases.backupPhase3.Output.path }}'                                                                                                                                                                                
    blueprint: operator-blueprint                         
    deferPhase:                                           
      name: ""                                            
      progress: {}                                        
      state: ""                                           
    name: backup                                          
    object:                                               
      apiVersion: ""                                      
      group: ""                                           
      kind: statefulset                                   
      name: mysql                                         
      namespace: mysql                                    
      resource: ""                                        
    phases:                                               
    - name: backupPhase1                                  
      output:                                             
        path: /operator-backups/2023-08-11T06-41-03/backup.tgz                                                      
      progress:                                           
        lastTransitionTime: "2023-08-11T06:41:22Z"                                                                  
        progressPercent: "100"                            
      state: complete                                     
    - name: backupPhase2                                  
      progress: {}                                        
      state: running                                      
    - name: backupPhase3                                  
      progress: {}                                        
      state: pending                                      
  - blueprint: operator-blueprint                         
    deferPhase:                                           
      name: ""                                            
      progress: {}                                        
      state: ""                                           
    name: restore                                         
    object:                                               
      apiVersion: ""                                      
      group: ""                                           
      kind: statefulset                                   
      name: mysql                                         
      namespace: mysql                                    
      resource: ""                                        
    phases:                                               
    - name: restorePhase1                                 
      progress:                                           
        lastTransitionTime: "2023-08-11T06:41:18Z"                                                                  
        progressPercent: "100"                            
      state: complete                                     
    - name: restorePhase2                                 
      progress:                                           
        lastTransitionTime: "2023-08-11T06:41:23Z"                                                                  
        progressPercent: "0"                              
      state: running                                      
    - name: restorePhase3                                 
      progress: {}                                        
      state: pending                                      
  error:                                                  
    message: ""                                           
  progress:                                               
    lastTransitionTime: "2023-08-11T06:41:22Z"            
    percentCompleted: "33"                                
    runningPhase: backupPhase2                            
  state: running

4. 2nd phase of second action is completed

status:                                                                                                                                                                                                                       [849/4603]
  actions:                                                                                                                                                                                                                              
  - artifacts:                                                                                                                                                                                                                          
      operatorBackup:                                                                                                                                                                                                                   
        keyValue:                                                                                                                                                                                                                       
          path: '{{ .Phases.backupPhase3.Output.path }}'                                                                                                                                                                                
    blueprint: operator-blueprint                                                                                                                                                                                                       
    deferPhase:                                                                                                                                                                                                                         
      name: ""                                                                                                                                                                                                                          
      progress: {}                                                                                                                                                                                                                      
      state: ""                                                                                                                                                                                                                         
    name: backup                                                                                                                                                                                                                        
    object:                                                                                                                                                                                                                             
      apiVersion: ""                                                                                                                                                                                                                    
      group: ""                                                                                                                                                                                                                         
      kind: statefulset                                                                                                                                                                                                                 
      name: mysql                                                                                                                                                                                                                       
      namespace: mysql                                                                                                                                                                                                                  
      resource: ""                                                                                                                                                                                                                      
    phases:                                               
    - name: backupPhase1                                                                                            
      output:                                             
        path: /operator-backups/2023-08-11T06-41-03/backup.tgz                                                      
      progress:                                           
        lastTransitionTime: "2023-08-11T06:41:22Z"                                                                  
        progressPercent: "100"                                                                                      
      state: complete                                     
    - name: backupPhase2                                  
      progress:                                                                                                     
        lastTransitionTime: "2023-08-11T06:41:27Z"                                                                  
        progressPercent: "0"                                                                                        
      state: running                                      
    - name: backupPhase3                                                                                            
      progress: {}                                                                                                  
      state: pending                                      
  - blueprint: operator-blueprint                         
    deferPhase:                                           
      name: ""                                                                                                      
      progress: {}                                        
      state: ""                                           
    name: restore                                         
    object:                                               
      apiVersion: ""                                      
      group: ""                                           
      kind: statefulset                                   
      name: mysql                                         
      namespace: mysql                                    
      resource: ""                                        
    phases:                                               
    - name: restorePhase1                                 
      progress:                                           
        lastTransitionTime: "2023-08-11T06:41:18Z"                                                                  
        progressPercent: "100"                            
      state: complete                                     
    - name: restorePhase2                                 
      progress:                                           
        lastTransitionTime: "2023-08-11T06:41:33Z"                                                                  
        progressPercent: "100"                            
      state: complete                                     
    - name: restorePhase3                                 
      progress: {}                                        
      state: running                                      
  error:                                                  
    message: ""                                           
  progress:                                               
    lastTransitionTime: "2023-08-11T06:41:33Z"            
    percentCompleted: "50"                                
    runningPhase: restorePhase3                           
  state: running

5. All the actions are completed

status:                                                                                                             
  actions:                                                                                                          
  - artifacts:                                                                                                      
      operatorBackup:                                                                                               
        keyValue:                                                                                                   
          path: /operator-backups/2023-08-11T06-41-03/backup.tgz                                                    
    blueprint: operator-blueprint                         
    deferPhase:                                           
      name: ""                                            
      progress: {}                                        
      state: ""                                           
    name: backup                                          
    object:                                                                                                         
      apiVersion: ""                                                                                                
      group: ""                                                                                                     
      kind: statefulset                                                                                             
      name: mysql                                                                                                   
      namespace: mysql                                                                                              
      resource: ""                                                                                                  
    phases:                                                                                                         
    - name: backupPhase1                                                                                            
      output:                                                                                                       
        path: /operator-backups/2023-08-11T06-41-03/backup.tgz                                                      
      progress:                                                                                                     
        lastTransitionTime: "2023-08-11T06:41:22Z"                                                                  
        progressPercent: "100"                                                                                      
      state: complete                                                                                               
    - name: backupPhase2                                                                                            
      output:                                                                                                       
        path: /operator-backups/2023-08-11T06-41-03/backup.tgz                                                      
      progress:                                                                                                     
        lastTransitionTime: "2023-08-11T06:41:42Z"                                                                  
        progressPercent: "100"                                                                                      
      state: complete                                                                                               
    - name: backupPhase3                                                                                            
      output:                                                                                                       
        path: /operator-backups/2023-08-11T06-41-03/backup.tgz                                                      
      progress:                                                                                                     
        lastTransitionTime: "2023-08-11T06:42:02Z"                                                                  
        progressPercent: "100"                            
      state: complete                                     
  - blueprint: operator-blueprint                         
    deferPhase:                                           
      name: ""                                            
      progress: {}                                        
      state: ""                                           
    name: restore                                         
    object:                                                                                                         
      apiVersion: ""                                                                                                
      group: ""                                                                                                     
      kind: statefulset                                                                                             
      name: mysql                                                                                                   
      namespace: mysql                                                                                              
      resource: ""                                                                                                  
    phases:                                                                                                         
    - name: restorePhase1                                                                                           
      progress:                                                                                                     
        lastTransitionTime: "2023-08-11T06:41:18Z"                                                                  
        progressPercent: "100"                                                                                      
      state: complete                                                                                               
    - name: restorePhase2                                                                                           
      progress:                                                                                                     
        lastTransitionTime: "2023-08-11T06:41:33Z"                                                                  
        progressPercent: "100"                                                                                      
      state: complete                                                                                               
    - name: restorePhase3                                                                                           
      progress:                                                                                                     
        lastTransitionTime: "2023-08-11T06:41:47Z"                                                                  
        progressPercent: "100"                            
      state: complete                                     
  error:                                                  
    message: ""                                           
  progress:                                               
    lastTransitionTime: "2023-08-11T06:41:52Z"            
    percentCompleted: "100"                               
  state: complete

github-actions · 2023-04-17T11:31:50Z

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

pkg/progress/action.go

pkg/apis/cr/v1alpha1/types.go

viveksinghggits · 2023-06-09T09:07:56Z

pkg/controller/controller.go

 				output, err = p.Exec(ctx, *bp, action.Name, *tp)
+				doneProgressTrack()


do we need to call it again even after calling it from defer ?

Yes, the doneProgressTrack() needs to be called as soon as Exec() is done. The defer() gets called once all the phase Exec is done and action is completed (or failed). When the next phase execution starts during interaction in this function, the older phase's Progress() starts sending completion percent as 0. So before running next phase, the goroutine for current phase needs to be closed. Let me know if this makes sense or not.

pkg/function/backup_data.go

pkg/kanister.go

pkg/controller/controller.go

viveksinghggits · 2023-06-09T09:52:55Z

The other question that I had was, how are we going to handle the Kopia related function. Some functions are already, in so they are going to break right?

PrasadG193 · 2023-06-13T11:09:43Z

@viveksinghggits I've already rebased the PR with master which has kopia based function. I've implemented ExecProgress() for those as well.

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

viveksinghggits

looks good to me almost, just some small questions.

pkg/apis/cr/v1alpha1/types.go

viveksinghggits · 2023-06-26T08:29:43Z

pkg/progress/action.go

+			if actionSet.Status.Actions[i].Phases[j].Name != phaseName {
+				continue
+			}
+			if actionSet.Status.Actions[i].Phases[j].State == crv1alpha1.StatePending ||
+				actionSet.Status.Actions[i].Phases[j].State == crv1alpha1.StateFailed {
+				continue
+			}


should we combine these two statements? I am ok with this change if you think it's more readable.

pkg/controller/controller.go

PrasadG193 · 2023-07-06T05:36:41Z

@pavannd1 could you please take a look?

pkg/apis/cr/v1alpha1/types.go

pkg/controller/controller.go

pkg/phase.go

pkg/progress/action.go

pkg/controller/controller.go

Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

PrasadG193 · 2023-08-11T06:57:55Z

Added test case scenario when executing multiple actions with the same blueprint in the PR's test plan. @pavannd1 @viveksinghggits PTAL

viveksinghggits · 2023-08-11T12:48:47Z

Added test case scenario when executing multiple actions with the same blueprint in the PR's test plan. @pavannd1 @viveksinghggits PTAL

I had already looked into the PR so I am going to skip 🍏 , but just wanted to make sure that the issue that we talked about where two actions are running in parallel is not going to cause any issues with runningPhase right?
If yes, do we have a ticket/issue somewhere to track that?

PrasadG193 · 2023-08-16T12:37:10Z

@viveksinghggits I've filed - #2270

PrasadG193 · 2023-08-30T06:45:56Z

@pavannd1 could you please re-review the PR?

pavannd1

LGTM. Feel free to merge once CI passes.

* Implement ExecutionProgress method on Kanister functions Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Set LastTransitionTime in ExecutionProgress return Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Update pkg/function/backup_data.go Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com> --------- Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>

Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>

…rogress (#2023) * Add phase level progress fields in actionset object Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Change weight based progress calc with func implementation Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Refactor and add unit tests for phase progress Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Update generated deepcopy methods Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Fix import cycle issue in test Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Update pkg/apis/cr/v1alpha1/types.go Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com> * Update pkg/apis/cr/v1alpha1/types.go Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com> * Update pkg/apis/cr/v1alpha1/types.go Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com> * Update pkg/apis/cr/v1alpha1/types.go Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com> * Use correct action index while updating action phase state Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Implement ExecutionProgress method on Kanister functions (#2117) * Implement ExecutionProgress method on Kanister functions Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Set LastTransitionTime in ExecutionProgress return Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Update pkg/function/backup_data.go Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com> --------- Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com> * Implement ExecProgress on test function Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com> * Remove unused mockPhase in test Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com> * Remove unnecessary whitespace in updateActionProgress func Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com> --------- Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com> Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

infraq added this to In Progress in Kanister Apr 17, 2023

PrasadG193 force-pushed the phase-progress-interface branch from 37e30eb to 5146900 Compare April 19, 2023 13:07

PrasadG193 force-pushed the phase-progress-interface branch from 5146900 to e2ea4ef Compare May 11, 2023 07:06

PrasadG193 marked this pull request as ready for review May 11, 2023 17:36

PrasadG193 force-pushed the phase-progress-interface branch 2 times, most recently from c8f8520 to defe297 Compare May 22, 2023 18:07

PrasadG193 requested review from pavannd1, viveksinghggits and r4rajat May 22, 2023 18:11

PrasadG193 force-pushed the phase-progress-interface branch from defe297 to 2eadae1 Compare June 6, 2023 12:09

Add phase level progress fields in actionset object

8aacea2

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

PrasadG193 force-pushed the phase-progress-interface branch from 2eadae1 to 3402512 Compare June 7, 2023 04:55

viveksinghggits reviewed Jun 9, 2023

View reviewed changes

PrasadG193 added 3 commits June 16, 2023 12:12

Change weight based progress calc with func implementation

508247c

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

Refactor and add unit tests for phase progress

ea1cdd6

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

Update generated deepcopy methods

35c5578

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

PrasadG193 changed the title ~~Add ExecProgress() method to function interface to report exec progress~~ Add ExecutionProgress() method to function interface to report exec progress Jun 16, 2023

PrasadG193 force-pushed the phase-progress-interface branch from eed913b to 35c5578 Compare June 16, 2023 06:46

PrasadG193 mentioned this pull request Jun 16, 2023

Implement ExecutionProgress method on Kanister functions #2117

Merged

7 tasks

PrasadG193 requested a review from viveksinghggits June 19, 2023 06:55

Fix import cycle issue in test

72c2bb6

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

viveksinghggits reviewed Jun 26, 2023

View reviewed changes

PrasadG193 added 2 commits July 17, 2023 16:45

Merge branch 'master' into phase-progress-interface

135b55c

Merge branch 'master' into phase-progress-interface

b14874f

pavannd1 reviewed Jul 25, 2023

View reviewed changes

Update pkg/apis/cr/v1alpha1/types.go

68a075e

Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>

PrasadG193 and others added 5 commits August 4, 2023 12:00

Update pkg/apis/cr/v1alpha1/types.go

b0e53a5

Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>

Update pkg/apis/cr/v1alpha1/types.go

8da47fa

Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>

Update pkg/apis/cr/v1alpha1/types.go

090539b

Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>

Merge branch 'master' into phase-progress-interface

caff247

Use correct action index while updating action phase state

5529275

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

PrasadG193 requested review from pavannd1 and viveksinghggits August 11, 2023 09:54

Merge branch 'master' into phase-progress-interface

65db94a

pavannd1 approved these changes Sep 13, 2023

View reviewed changes

Kanister automation moved this from In Progress to Reviewer approved Sep 13, 2023

PrasadG193 and others added 5 commits September 20, 2023 15:55

Merge branch 'master' into phase-progress-interface

afd882d

Merge branch 'master' into phase-progress-interface

83d12c9

Implement ExecProgress on test function

6603d94

Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>

Remove unused mockPhase in test

d1aa60f

Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>

PrasadG193 added the kueue label Sep 27, 2023

PrasadG193 and others added 2 commits October 3, 2023 12:10

Remove unnecessary whitespace in updateActionProgress func

22eaade

Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>

Merge branch 'master' into phase-progress-interface

73445d4

mergify bot merged commit f9d0fdc into master Oct 3, 2023
15 checks passed

Kanister automation moved this from Reviewer approved to Done Oct 3, 2023

mergify bot deleted the phase-progress-interface branch October 3, 2023 08:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ExecutionProgress() method to function interface to report exec progress #2023

Add ExecutionProgress() method to function interface to report exec progress #2023

PrasadG193 commented Apr 17, 2023 •

edited

Loading

github-actions bot commented Apr 17, 2023

viveksinghggits Jun 9, 2023

PrasadG193 Jun 13, 2023

viveksinghggits commented Jun 9, 2023

PrasadG193 commented Jun 13, 2023

viveksinghggits left a comment

viveksinghggits Jun 26, 2023

PrasadG193 commented Jul 6, 2023

PrasadG193 commented Aug 11, 2023

viveksinghggits commented Aug 11, 2023

PrasadG193 commented Aug 16, 2023

PrasadG193 commented Aug 30, 2023

pavannd1 left a comment

		output, err = p.Exec(ctx, bp, action.Name, tp)
		doneProgressTrack()

Add ExecutionProgress() method to function interface to report exec progress #2023

Add ExecutionProgress() method to function interface to report exec progress #2023

Conversation

PrasadG193 commented Apr 17, 2023 • edited Loading

Change Overview

Pull request type

Issues

Test Plan

Sample output of actionSet status of each phase completion status

TC:1 Blueprint action consists of 3 phases and all phases succeeds

TC:2 Blueprint consists of 3 phases, first phases succeeds and 2nd one fails

TC:3 Blueprint with actions having multiple phases. And actionset running multiple action

github-actions bot commented Apr 17, 2023

viveksinghggits Jun 9, 2023

Choose a reason for hiding this comment

PrasadG193 Jun 13, 2023

Choose a reason for hiding this comment

viveksinghggits commented Jun 9, 2023

PrasadG193 commented Jun 13, 2023

viveksinghggits left a comment

Choose a reason for hiding this comment

viveksinghggits Jun 26, 2023

Choose a reason for hiding this comment

PrasadG193 commented Jul 6, 2023

PrasadG193 commented Aug 11, 2023

viveksinghggits commented Aug 11, 2023

PrasadG193 commented Aug 16, 2023

PrasadG193 commented Aug 30, 2023

pavannd1 left a comment

Choose a reason for hiding this comment

PrasadG193 commented Apr 17, 2023 •

edited

Loading