Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make repository cache settings configurable using repository server CR #1918

Merged
merged 281 commits into from
May 25, 2023
Merged

Make repository cache settings configurable using repository server CR #1918

merged 281 commits into from
May 25, 2023

Conversation

kale-amruta
Copy link
Contributor

@kale-amruta kale-amruta commented Feb 20, 2023 •
edited

Change Overview

Currently the metadata/content cache settings required while connecting to kopia repository are not configurable in the repository server controller. This PR makes it configurable through CR

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

shlokc9 and others added 30 commits September 30, 2022 13:23
@shlokc9
Remove RepositoryServerResource from CreateCustomResources list since…
d40f441 
… it's used by Kanister controller
@shlokc9
Add a tag for repositoryserver.yaml from customresource files in pkg/…
d29c0b4 
…customresource/embed.go
@ihcsim @mergify @shlokc9
Add new webinar link to README (#1643)
7c64c70 
Signed-off-by: Ivan Sim <ivan.sim@kasten.io>

Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@shlokc9
Remove noStatus local tag from RepositoryServer in types.go to genera…
705f594 
…te UpdateStatus code for it
@shlokc9
Add Status subresource to RepositoryServer CRD
6cfe482
@shlokc9
Merge branch 'master' of github.com:kanisterio/kanister into kopia-re…
cf1a296 
…pository-server-crd
@shlokc9
Merge branch 'kopia-repository-server-crd' of github.com:kanisterio/k…
d51d7e1 
…anister into kopia-repository-server-controller
@shlokc9
Add the 'Ref' suffix to SecretReference CRD fields, update NetworkPol…
82c79d5 
…icy labelselector field and replace some omitempty CRD fields to required
@shlokc9
Merge branch 'master' of github.com:kanisterio/kanister into kopia-re…
74c3d73 
…pository-server-crd
@shlokc9
Merge branch 'kopia-repository-server-crd' of github.com:kanisterio/k…
4fbbb27 
…anister into kopia-repository-server-controller
@shlokc9
Remove kubebuilder specific annotations from CRD YAML
5fcfed7
@shlokc9
Merge branch 'kopia-repository-server-crd' of github.com:kanisterio/k…
e256764 
…anister into kopia-repository-server-controller
@shlokc9
Add Handler and few utility functions to the RepositoryServer controller
e4c6bad
@shlokc9
Update CRD type and deepcopy function to fix the pod and namespace La…
e221a41 
…belSelector error
@shlokc9
Merge branch 'kopia-repository-server-crd' of github.com:kanisterio/k…
a459101 
…anister into kopia-repository-server-controller
@shlokc9
Update controller to use podSelector and namespaceSelector from CR to…
1e833c3 
… define ingress traffic for repo server pod
@shlokc9
Merge branch 'master' of github.com:kanisterio/kanister into kopia-re…
bd532c4 
…pository-server-crd
@shlokc9
Added Kubebuilder skeleton code
a44589f
@shlokc9
Revert go.sum
cbb3d82
@shlokc9
Merge branch 'master' of github.com:kanisterio/kanister into kopia-re…
abaf376 
…pository-server-crd
@shlokc9
Merge branch 'kopia-repository-server-crd' of github.com:kanisterio/k…
5446a89 
…anister into kopia-repository-server-controller
@shlokc9
Fix vet and fmt target in Kubebuilder.mk
7536217
@shlokc9
Merge branch 'kopia-repository-server-crd' of github.com:kanisterio/k…
8ee390d 
…anister into kopia-repository-server-controller
@shlokc9
Merge Kubebuilder.mk and Makefile
965dcc3
@shlokc9
Merge branch 'master' of github.com:kanisterio/kanister into kopia-re…
c1b0b61 
…pository-server-crd
@shlokc9
Merge branch 'kopia-repository-server-crd' of github.com:kanisterio/k…
07436e7 
…anister into kopia-repository-server-controller
@shlokc9
Remove TODO in Makefile to update the 'test' target name
a6c5647
@shlokc9
Merge branch 'kopia-repository-server-crd' of github.com:kanisterio/k…
02dee9e 
…anister into kopia-repository-server-controller
@shlokc9
Rename Kubebuilder build, test, run, deploy and undeploy targets in M…
eb7766a 
…akefile
@shlokc9
Merge branch 'kopia-repository-server-crd' of github.com:kanisterio/k…
c735763 
…anister into kopia-repository-server-controller
ankitjain235
ankitjain235 reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor questions, looks good otherwise.

pkg/controllers/repositoryserver/repository.go Show resolved Hide resolved
pkg/apis/cr/v1alpha1/repositoryserver_types.go Outdated Show resolved Hide resolved
Base automatically changed from kopia-repository-server-controller-deployment to master May 3, 2023 08:38
ankitjain235
ankitjain235 approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kale-amruta kale-amruta requested a review from pavannd1 May 24, 2023 06:54
@pavannd1 pavannd1 removed the kueue label May 25, 2023
Kanister automation moved this from Review Required to Reviewer approved May 25, 2023
@pavannd1 pavannd1 added the kueue label May 25, 2023
@mergify mergify bot merged commit f88b9fa into master May 25, 2023
Kanister automation moved this from Reviewer approved to Done May 25, 2023
@mergify mergify bot deleted the kopia-repository-server-cache-settings branch May 25, 2023 23:08
@PrasadG193
Copy link
Contributor

@kale-amruta we need to run codegen after these changes. Can you please raise a PR?

@kale-amruta kale-amruta mentioned this pull request Jun 6, 2023
Merged
10 tasks
@r4rajat r4rajat mentioned this pull request Jun 15, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@ankitjain235 ankitjain235 ankitjain235 approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kale-amruta @PrasadG193 @pavannd1 @ankitjain235 @shlokc9 @ihcsim