Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating deep copy functions for cache settings in repository server CR #2090

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

kale-amruta
Copy link
Contributor

Change Overview

Its a follow up PR addressing the comment on this PR - #1918 (comment)

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jun 6, 2023
Kanister automation moved this from In Progress to Reviewer approved Jun 6, 2023
@kale-amruta kale-amruta changed the title Generating deep copy functions for cache settings in repository server PR Generating deep copy functions for cache settings in repository server CR Jun 6, 2023
@mergify mergify bot merged commit 94448f6 into master Jun 6, 2023
16 checks passed
Kanister automation moved this from Reviewer approved to Done Jun 6, 2023
@mergify mergify bot deleted the makeCodegenForcachesettings branch June 6, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants