Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mongo-sidecar image build from goreleaser #2096

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Remove mongo-sidecar image build from goreleaser #2096

merged 5 commits into from
Jun 12, 2023

Conversation

PrasadG193
Copy link
Contributor

Change Overview

  • Remove mongo-sidecar build from goreleaser config
  • Update mongo sidecar Dockerfile to work with docker build
  • Add docker image build steps in mongo-sidecar example

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

Successfully built mongo-sidecar image using documented steps

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@PrasadG193
Remove mongo-sidecar build from goreleaser config
bf99fed 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193
Update mongo sidecar Dockerfile to work with docker build
883540d 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193
Add docker image build steps in mongo-sidecar example
72d69f6 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jun 12, 2023
viveksinghggits
viveksinghggits reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/mongo-sidecar/README.md Outdated Show resolved Hide resolved
Kanister automation moved this from In Progress to Reviewer approved Jun 12, 2023
@PrasadG193 @viveksinghggits
Update examples/mongo-sidecar/README.md
5625aea 
Co-authored-by: Vivek Singh <vsingh.ggits.2010@gmail.com>
@mergify mergify bot merged commit be0f4e9 into master Jun 12, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Jun 12, 2023
@mergify mergify bot deleted the skip-mongo-sidecar-build branch June 12, 2023 14:58
viveksinghggits added a commit that referenced this pull request Jun 13, 2023
@viveksinghggits
Correct push_images.sh to not push removed images
ed9ead3 
As part of PRs #2099
and #2096 we removed
the `couchbase-tools` and `mongo-sidecar` images from goreleaser,
this PR removes them from push_images.sh as well so that they are
not tried to be pushed automatically.
@viveksinghggits viveksinghggits mentioned this pull request Jun 13, 2023
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Jun 13, 2023
@viveksinghggits
Correct push_images.sh to not push removed images (#2101)
3306bbc 
As part of PRs #2099
and #2096 we removed
the `couchbase-tools` and `mongo-sidecar` images from goreleaser,
this PR removes them from push_images.sh as well so that they are
not tried to be pushed automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

@akankshakumari393 akankshakumari393 Awaiting requested review from akankshakumari393

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PrasadG193 @viveksinghggits