Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct push_images.sh to not push removed images #2101

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

As part of PRs #2099 and #2096 we removed the couchbase-tools and mongo-sidecar images from goreleaser, this PR removes them from push_images.sh as well so that they are not tried to be pushed automatically.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

NA

As part of PRs #2099
and #2096 we removed
the `couchbase-tools` and `mongo-sidecar` images from goreleaser,
this PR removes them from push_images.sh as well so that they are
not tried to be pushed automatically.
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jun 13, 2023
Kanister automation moved this from In Progress to Reviewer approved Jun 13, 2023
@mergify mergify bot merged commit 3306bbc into master Jun 13, 2023
16 checks passed
Kanister automation moved this from Reviewer approved to Done Jun 13, 2023
@mergify mergify bot deleted the remove-removedimage branch June 13, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants