-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run postgresql integration test on latest chart #2196
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
pkg/app/postgresql.go
Outdated
@@ -49,7 +49,7 @@ func NewPostgresDB(name string, subPath string) App { | |||
RepoName: helm.BitnamiRepoName, | |||
RepoURL: helm.BitnamiRepoURL, | |||
Chart: "postgresql", | |||
Version: "12.6.0", // TODO: Revert once #2155 is addressed | |||
// Version: "12.6.0", // use latest chart version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
0b239dd
to
5befbce
Compare
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
5befbce
to
b5f05d4
Compare
Change Overview
Integration tests for postgres were failing for postgresql app with latest helm chart.
This PR reverts to the latest working version of postgres helm chart from earlier temporary fix version i.e 12.6.0 for the test app.
Generate random password as following were being ignored
Bug was reported for the same at bitnami/postgresql. New chart version fixed the issue.
Depends on: #2206
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Successfully ran integration tests for PostgreSQL application