Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run postgresql integration test on latest chart #2196

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Conversation

mabhi
Copy link
Contributor

@mabhi mabhi commented Jul 19, 2023

Change Overview

Integration tests for postgres were failing for postgresql app with latest helm chart.
This PR reverts to the latest working version of postgres helm chart from earlier temporary fix version i.e 12.6.0 for the test app.

Generate random password as following were being ignored

  • global.postgresql.auth.postgresPassword
  • auth.postgresPassword
    Bug was reported for the same at bitnami/postgresql. New chart version fixed the issue.

Depends on: #2206

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

Successfully ran integration tests for PostgreSQL application


./build/integration-test.sh ^PostgreSQL$
Running integration tests:
...
...
...
{"File":"pkg/app/postgresql.go","Function":"github.com/kanisterio/kanister/pkg/app.PostgresDB.Uninstall","Line":199,"app":"postgres","cluster_name":"4e3c7620-4569-4d87-8f7d-0f22884ca1ed","level":"info","msg":"Uninstalling helm chart.","namespace":"postgres-test","release":"postgres-cdqkp","time":"2023-07-19T10:24:25.000370184+05:30"}
OK: 1 passed
--- PASS: Test (68.09s)
PASS
ok      github.com/kanisterio/kanister/pkg/testing      68.132s
  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jul 19, 2023
@PrasadG193 PrasadG193 self-requested a review July 19, 2023 07:34
@@ -49,7 +49,7 @@ func NewPostgresDB(name string, subPath string) App {
RepoName: helm.BitnamiRepoName,
RepoURL: helm.BitnamiRepoURL,
Chart: "postgresql",
Version: "12.6.0", // TODO: Revert once #2155 is addressed
// Version: "12.6.0", // use latest chart version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
Kanister automation moved this from In Progress to Reviewer approved Jul 25, 2023
@mabhi mabhi added the kueue label Jul 28, 2023
@mergify mergify bot merged commit d745629 into master Jul 28, 2023
15 checks passed
Kanister automation moved this from Reviewer approved to Done Jul 28, 2023
@mergify mergify bot deleted the fix-postgres-e2e-test branch July 28, 2023 09:36
pavannd1 added a commit that referenced this pull request Aug 5, 2023
mergify bot pushed a commit that referenced this pull request Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Integration tests failing for PostgreSQL application
3 participants