Bump helm version in kanister build #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of helm used inside kanister binary is causing integration tests to fail. This happen for the latest Postgresql helm charts. This is necessary as the bitnami helm chart for psotgresql has undergone changes in their handling of secrets and setting passwords during helm install. Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
pavannd1
reviewed
Jul 20, 2023
| @@ -62,7 +62,8 @@ IMAGE_NAME := $(BIN) | |||
|
|
|||
| IMAGE := $(REGISTRY)/$(IMAGE_NAME) | |||
|
|
|||
| BUILD_IMAGE ?= ghcr.io/kanisterio/build:v0.0.23 | |||
There was a problem hiding this comment.
Sure @pavannd1 , I actually was looking for this. For the time being I tested with a docker image to validate. Will push a new commit after running the workflow.
Reverted old reference of test build image. Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
mabhi
changed the title
10 tasks
mabhi
changed the title
PrasadG193
approved these changes
Jul 24, 2023
mabhi
added a commit
that referenced
this pull request
Jul 24, 2023
* Initial commit to bump helm version. The previous version of helm used inside kanister binary is causing integration tests to fail. This happen for the latest Postgresql helm charts. This is necessary as the bitnami helm chart for psotgresql has undergone changes in their handling of secrets and setting passwords during helm install. Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io> * Makefile points to new build image with latest helm version Reverted old reference of test build image. Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io> --------- Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The previous version of helm used inside kanister binary is causing integration tests to fail. This happen for the latest PostgreSql helm charts.
This PR is necessary as the bitnami helm chart for PostgreSql has undergone changes in their handling of secrets and setting passwords during helm install causing parsing errors during integration test. The bitnami fix is now available in the latest charts.
This bumps version from
3.2.0->3.12.2Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan