Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable misspell, nestif golang linter #2240
Enable misspell, nestif golang linter #2240
Changes from 11 commits
41261a0
118bc8a
9fe8ef0
88f1097
cf599c9
4c91b50
54d1d5e
ad04108
953121f
605f039
31e838f
b4cf462
2f1bbe4
ef78a07
62b8959
41933d9
9c3b9a1
44a39cb
a874943
612154b
0007316
7a3945a
75b4f9d
bc30421
6695929
8c38dc0
d522754
32f0cae
fded60e
3f68dab
08e0240
e30c1ce
5b6234c
5e97339
da05972
a8795b2
95d4b08
7e7f3bf
446c437
8727b06
a435fdf
74180ac
722b3f8
b7c7b3a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine to enable
misspell
in test file if doesn't require much changesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does require changes. Enabling these linters for tests would need a lot of extra work. I'll create a separate issue for the same?