Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RepositoryServer datamover tests #2249

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Aug 9, 2023

Change Overview

Refactored following

  • Delete whole namespace instead of individual resources in cleanup
  • Setting Environmental Variables for the repo-server container via secrets instead directly

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

$ make install-minio
$ export S3_COMPLIANT_AWS_ACCESS_KEY_ID="AKIAIOSFODNN7EXAMPLE"
$ export S3_COMPLIANT_AWS_SECRET_ACCESS_KEY="wJad@9gkeFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"
$ export S3_COMPLIANT_LOCATION_ENDPOINT="http://minio.minio.svc.cluster.local:9000"
$ cd pkg/datamover

$ go test

...
...
...
...
OK: 2 passed
PASS
ok      github.com/kanisterio/kanister/pkg/datamover    16.737s
  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Kanister automation moved this from In Progress to Reviewer approved Aug 9, 2023
@r4rajat r4rajat added the kueue label Aug 9, 2023
@pavannd1
Copy link
Contributor

pavannd1 commented Aug 9, 2023

Possible race in the test. This could potentially cause flaky failures.

----------------------------------------------------------------------
FAIL: repositoryserver_controller_test.go:208: RepoServerControllerSuite.TestRepositoryServerImmutability

repositoryserver_controller_test.go:230:
    c.Assert(err.Error(), Equals, expectedErrorMessage)
... obtained string = "Operation cannot be fulfilled on repositoryservers.cr.kanister.io \"test-kopia-repo-server-6j9hk\": the object has been modified; please apply your changes to the latest version and try again"
... expected string = "RepositoryServer.cr.kanister.io \"test-kopia-repo-server-6j9hk\" is invalid: spec.repository.rootPath: Invalid value: \"string\": Value is immutable"

@mergify mergify bot merged commit ae250ce into master Aug 10, 2023
15 checks passed
@mergify mergify bot deleted the fix-repo-server-datamover-tests branch August 10, 2023 00:13
Kanister automation moved this from Reviewer approved to Done Aug 10, 2023
kale-amruta added a commit that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants