Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add Tests for updated Interface based kando command line" #2253

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

kale-amruta
Copy link
Contributor

@kale-amruta kale-amruta commented Aug 10, 2023

Change Overview

This is a manual revert of the PR #2168 and #2166, since another PR (#2249) was merged after this PR which had changes in the same files

Reason for reverting the PR

  • If we run the tests from outside the cluster, the kopia repository server pod cannot be accessed which causes the tests to fail with error:
{"File":"pkg/kopia/repository/client.go","Function":"github.com/kanisterio/kanister/pkg/kopia/repository.ConnectToAPIServer.func1","Line":86,"cluster_name":"b5163a6a-541d-426f-80c0-36be90ce7a5c","error":"unable to get repository parameters: error running http request: Get \"https://10.4.0.27:32416/api/v1/repo/parameters\": round-trip error: dial tcp 10.4.0.27:32416: i/o timeout","hostname":"23bc38dd7dc5","level":"debug","msg":"Connecting to the Kopia API Server","time":"2023-08-09T12:11:01.852459839Z"}

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Aug 10, 2023
Kanister automation moved this from In Progress to Reviewer approved Aug 10, 2023
@kale-amruta kale-amruta added kueue and removed kueue labels Aug 10, 2023
@mergify mergify bot merged commit 81766ec into master Aug 10, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Aug 10, 2023
@mergify mergify bot deleted the revertDataMoverTests branch August 10, 2023 09:10
r4rajat added a commit that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants