Fix issue with missing container name and namespace

[chaitalisg]

Change Overview

When creating pods with sidecars, we have an issue with writing files or streaming logs from these pods, because such operations requires container name.
This PR fixes this issue.

Pull request type

Please check the type of change your PR introduces:

• 🚧 Work in Progress
• 🌈 Refactoring (no functional changes, no api changes)
• 🐹 Trivial/Minor
• 🐛 Bugfix
• 🌻 Feature
• 🗺️ Documentation
• 🤖 Test

Issues

• fixes #issue-number

Test Plan

• 💪 Manual
• ⚡ Unit test
• 💚 E2E

[github-actions]

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

[pavannd1]

LGTM

[viveksinghggits]

Hi @chaitalisg,
Like mentioned in the PR description in case of multiple containers in a pod when we try to read logs there was a problem. But how do we know that it's the first container that we want to read the logs from?
cc @pavannd1

[chaitalisg]

Hi @chaitalisg,
Like mentioned in the PR description in case of multiple containers in a pod when we try to read logs there was a problem. But how do we know that it's the first container that we want to read the logs from?
cc @pavannd1

Good question. It is a calculated risk. When pods are created with sidecars, sidecar containers are placed after main container. So, I am using the first container. Let me know if you know a way to make this better!

[viveksinghggits]

When pods are created with sidecars, sidecar containers are placed after main container.

I don't think this is the case always.
I think we should pass the container name explicitly instead. For example if we have a utility to exec into a pod it should expect a container name, similarly in this case since we are trying to get logs of a container we should explicitly expect the container name.
This can default to the container name that we set in podOptions while creating the pod because the is the that we would be interested in.

[viveksinghggits]

I have raised this PR that fixes above problem
#2310 (comment)