Change the way we figure out container to read the artifacts from #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While running the kanister function, to read the artifact that the phase has produced we get the logs of the kanister function pod (let's say `KubeTask`). If there is just one container in the KubeTask pod in that case things would work but if there are multiple contianers in the pod (let's say service mesh injected one), in that case the logic that we have to figure out the container name was not efficient. If was relying on the first container of the pod. This commit changes that logic to read the container name from `podOptions` or fallback to the default container name. This should work in all the cases, if container name is not specified while creating `podOptions` we will use default container name everywhere otherwise we will use the container name that is spec ified in the podOptions.
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
viveksinghggits
changed the title
10 tasks
When we create pod for a repo server CR, we try to figure out the `podOverride` which added (I am not sure why) a container with hardcoded name. This commit changes that and we figure out the container name from podOptions now.
|
@kale-amruta FYI, I have added some code related to repo server as well. |
|
@pavannd1 the main change is in |
pavannd1
reviewed
Sep 7, 2023
|
/ok-to-test |
pavannd1
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
While running the kanister function, to read the artifact that the phase has produced we get the logs of the kanister function pod (let's say
KubeTask). If there is just one container in the KubeTask pod in that case things would work but if there are multiple contianers in the pod (let's say service mesh injected one), in that case the logic that we have to figure out the container name was not efficient. If was relying on the first container of the pod.This PR changes that logic to read the container name from
podOptionsor fallback to the default container name. This should work in all the cases, if container name is not specified while creatingpodOptionswe will use default container name everywhere otherwise we will use the container name that is specified in the podOptions.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan