Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the way we figure out container to read the artifacts from #2310

Merged
merged 7 commits into from
Sep 7, 2023
Merged

Change the way we figure out container to read the artifacts from #2310

merged 7 commits into from
Sep 7, 2023

Commits on Sep 7, 2023

  1. Change how we figure out container to get logs from 

    While running the kanister function, to read the artifact that the phase has
produced we get the logs of the kanister function pod (let's say `KubeTask`).
If there is just one container in the KubeTask pod in that case things would
work but if there are multiple contianers in the pod (let's say service mesh
injected one), in that case the logic that we have to figure out the container
name was not efficient. If was relying on the first container of the pod.

This commit changes that logic to read the container name from `podOptions` or
fallback to the default container name. This should work in all the cases, if
container name is not specified while creating `podOptions` we will use default
container name everywhere otherwise we will use the container name that is spec
ified in the podOptions.
    @viveksinghggits
    viveksinghggits committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    ce4c498 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate code that was overreding container name

    @viveksinghggits
    viveksinghggits committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a62574e View commit details
    Browse the repository at this point in the history

  3. Export the util fun containerNameFromPodOpts

    @viveksinghggits
    viveksinghggits committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    f7bba23 View commit details
    Browse the repository at this point in the history

  4. Figure out container name from podOptions while creating repo server pod 

    When we create pod for a repo server CR, we try to figure out the `podOverride`
which added (I am not sure why) a container with hardcoded name. This commit
changes that and we figure out the container name from podOptions now.
    @viveksinghggits
    viveksinghggits committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a858387 View commit details
    Browse the repository at this point in the history

  5. Rename ContainerNameFromPodOpts to ContainerNameFromPodOptsOrDefault

    @viveksinghggits
    viveksinghggits committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    8786f82 View commit details
    Browse the repository at this point in the history

  6. Move ContainerNameFromPodOpts from pod_controller.go to pod.go

    @viveksinghggits
    viveksinghggits committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    92f4e4d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into containerfrom-po

    @mergify
    mergify[bot] authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    b65d69d View commit details
    Browse the repository at this point in the history