Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change the way we figure out container to read the artifacts from" #2314

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

pavannd1
Copy link
Contributor

@pavannd1 pavannd1 commented Sep 8, 2023

Reverts #2310

Breaks pod creation workflow in some cases.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Sep 8, 2023
@pavannd1 pavannd1 added the kueue label Sep 8, 2023
Kanister automation moved this from In Progress to Reviewer approved Sep 8, 2023
@mergify mergify bot merged commit dad529b into master Sep 8, 2023
16 checks passed
Kanister automation moved this from Reviewer approved to Done Sep 8, 2023
@mergify mergify bot deleted the revert-2310-containerfrom-po branch September 8, 2023 05:34
viveksinghggits added a commit that referenced this pull request Sep 8, 2023
viveksinghggits added a commit that referenced this pull request Sep 20, 2023
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
…tifacts from"" (#2316)

* Revert "Revert "Change the way we figure out container to read the artifacts from (#2310)" (#2314)"

This reverts commit dad529b.

* Make `ContainerNameFromPodOptsOrDefault` nil safe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants