Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify kopia utilities to use new kopia cache flags #2393

Merged
merged 17 commits into from
Oct 27, 2023
Merged

Modify kopia utilities to use new kopia cache flags #2393

merged 17 commits into from
Oct 27, 2023

Conversation

kale-amruta
Copy link
Contributor

@kale-amruta kale-amruta commented Oct 11, 2023 •
edited

Change Overview

Kopia has recently added a bunch of flags for cache settings while doing repository operations. This PR adds the options to set these flags in

  • Repository Create
  • Repostory Connect
  • Repository Server connect

Kopia Client related changes:

  • Since some of the kanister functions use repository server connect command, there were changes required in these functions as well
  • Kopia client changes in the function ConnectToAPIServer

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@infraq infraq added this to In Progress in Kanister Oct 11, 2023
@kale-amruta kale-amruta changed the base branch from master to addHardLimitscache October 17, 2023 11:40
@kale-amruta kale-amruta force-pushed the addNewCacheFlagsKanister branch 2 times, most recently from 6e80623 to b8cd4e0 Compare October 17, 2023 11:57
@kale-amruta kale-amruta changed the title [WIP] Add flags for hard limits on cache for kopia repository commands Modify repository create/connect command to use new kopia cache flags Oct 17, 2023
@kale-amruta kale-amruta changed the title Modify repository create/connect command to use new kopia cache flags Modify kopia repository create/connect command to use new kopia cache flags Oct 17, 2023
@kale-amruta kale-amruta changed the title Modify kopia repository create/connect command to use new kopia cache flags Modify kopia repository create/connect command to use new kopia cache flags(PR#2) Oct 17, 2023
Base automatically changed from addHardLimitscache to master October 20, 2023 06:09
@kale-amruta kale-amruta changed the title Modify kopia repository create/connect command to use new kopia cache flags(PR#2) Modify kopia repository CLI commands to use new kopia cache flags(PR#2) Oct 23, 2023
@kale-amruta kale-amruta changed the title Modify kopia repository CLI commands to use new kopia cache flags(PR#2) Modify kopia utilities to use new kopia cache flags(PR#2) Oct 23, 2023
@kale-amruta kale-amruta changed the base branch from master to update-kopia-to-upstream October 23, 2023 11:23
@kale-amruta kale-amruta changed the base branch from update-kopia-to-upstream to master October 23, 2023 11:29
@kale-amruta kale-amruta mentioned this pull request Oct 23, 2023
Closed
10 tasks
@kale-amruta kale-amruta changed the title Modify kopia utilities to use new kopia cache flags(PR#2) Modify kopia utilities to use new kopia cache flags Oct 23, 2023
kale-amruta
kale-amruta commented Oct 23, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
kale-amruta
kale-amruta commented Oct 23, 2023
View reviewed changes
go.sum Outdated Show resolved Hide resolved
ankitjain235
ankitjain235 requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking merge of the PR until the confusion in flag names is cleared.

Kanister automation moved this from In Progress to Review Required Oct 24, 2023
@kale-amruta kale-amruta mentioned this pull request Oct 24, 2023
Merged
10 tasks
@kale-amruta kale-amruta changed the base branch from master to update-kopia-to-upstream October 24, 2023 09:00
@kale-amruta kale-amruta changed the base branch from update-kopia-to-upstream to master October 24, 2023 09:11
ankitjain235
ankitjain235 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be good to be merged once testing is done.
Approving to unblock since I had requested changes.

pkg/kopia/command/repository_test.go Show resolved Hide resolved
pkg/kopia/command/cache.go Show resolved Hide resolved
Kanister automation moved this from Review Required to Reviewer approved Oct 24, 2023
pavannd1
pavannd1 reviewed Oct 25, 2023
View reviewed changes
pkg/kopia/command/cache.go Outdated Show resolved Hide resolved
pkg/kopia/command/repository_test.go Show resolved Hide resolved
@kale-amruta
add cache hard limit flags
006c0c6 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
add cache structure
b6c5df1 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
remove test changes
a02c15c 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
remove soft limit fields from the struct as we are not setting it
71e4908 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
move the unused function to child PR where the function is already used
7986e4b 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
add copyright headers to cache.go
472a658 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
modify repository create/connect command for new flags
55cc435 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
rename CacheCommandArgs to CacheArgs
b3ac984 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
refactor tests according to changes in repository connect command
e9ae632 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
fix data mover and repository controller tests according to changes i…
3a97d08 
…n repository create and connect command

Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
add kopiaCacheArgs function
279de65 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
changes in repository server connect SDK command
3c20afe 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
changes to kopia client
f5cfe1b 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
fix lint issues
4a64ebb 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta
format comments
6cd9c83 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@pavannd1 pavannd1 added the kueue label Oct 26, 2023
@mergify mergify bot merged commit 3e93315 into master Oct 27, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Oct 27, 2023
@mergify mergify bot deleted the addNewCacheFlagsKanister branch October 27, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@ankitjain235 ankitjain235 ankitjain235 approved these changes

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kale-amruta @pavannd1 @ankitjain235