Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kopia sdk to upstream v0.14.1 #2416

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Update kopia sdk to upstream v0.14.1 #2416

merged 7 commits into from
Oct 25, 2023

Conversation

leuyentran
Copy link
Contributor

@leuyentran leuyentran commented Oct 19, 2023 •
edited

Change Overview

In order to maintainin commit-parity for kopia between sdk in go.mo and kanister-tools image, these two PRs are a pair

This PR:

  • Upgrade kopia sdk to v0.14.1
  • Fix breaking changes in CacheOptions

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@infraq infraq added this to In Progress in Kanister Oct 19, 2023
@leuyentran leuyentran mentioned this pull request Oct 19, 2023
Merged
10 tasks
@leuyentran leuyentran changed the title Update kopia to upstream v0.14.1 Update kopia sdk to upstream v0.14.1 Oct 19, 2023
@kale-amruta kale-amruta mentioned this pull request Oct 23, 2023
Merged
10 tasks
KastenMike
KastenMike reviewed Oct 23, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
ankitjain235
ankitjain235 requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking merge of the PR until the confusion in flag names is cleared.

pkg/kopia/repository/client.go Show resolved Hide resolved
Kanister automation moved this from In Progress to Review Required Oct 24, 2023
ankitjain235
ankitjain235 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from Review Required to Reviewer approved Oct 24, 2023
@mergify mergify bot merged commit cba0e35 into master Oct 25, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Oct 25, 2023
@mergify mergify bot deleted the update-kopia-to-upstream branch October 25, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kale-amruta kale-amruta kale-amruta left review comments

@KastenMike KastenMike KastenMike left review comments

@ankitjain235 ankitjain235 ankitjain235 approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees

@ankitjain235 ankitjain235

@kale-amruta kale-amruta

Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leuyentran @ankitjain235 @kale-amruta @KastenMike @julio-lopez