Implement method SnapshotCreateWaitForCompletion for AdStorage type
#2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `SnapshotCreateWaitForCompletion` for `AdStorage` was just returning `nil`. Which caused some problems because we were not able to wait for snapshot to complete, successfully. This commit fixes that by implementing the mentioned method.
We checked if the snapshot was succeeded by making sure that these two conditions were false - err!=nil - provisioningState!=succeeded second condition can be false even if the provisioning state is pending, let's say. and because of that we would return success even in the case of err being not nil and provisioningStaet being pending. Which would be a problem. This fixes that.
kidgilson
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The method
SnapshotCreateWaitForCompletionforAdStoragewas just returningnil. Which caused some problems because we were not able to wait for snapshot to complete, successfully.This PR fixes that by implementing the mentioned method.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan