Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement method SnapshotCreateWaitForCompletion for AdStorage type #2494

Merged
merged 4 commits into from
Nov 28, 2023

Commits on Nov 23, 2023

  1. Implement method SnapshotCreateWaitForCompletion

    The method `SnapshotCreateWaitForCompletion` for `AdStorage` was just returning
    `nil`. Which caused some problems because we were not able to wait for snapshot
    to complete, successfully.
    This commit fixes that by implementing the mentioned method.
    viveksinghggits committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    243b370 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Correct logic that waits for snapshot to be succeeded

    We checked if the snapshot was succeeded by making sure that these two
    conditions were false
    
    - err!=nil
    - provisioningState!=succeeded
    
    second condition can be false even if the provisioning state is pending,
    let's say. and because of that we would return success even in the case
    of err being not nil and provisioningStaet being pending. Which would
    be a problem.
    This fixes that.
    viveksinghggits committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    e26f113 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Configuration menu
    Copy the full SHA
    59de52f View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Configuration menu
    Copy the full SHA
    3427c6a View commit details
    Browse the repository at this point in the history