Common exec error handling #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Dec 1, 2023
hairyhum
reviewed
Dec 1, 2023
| tty) | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
Is that necessary here?
It seems like this will change the behaviour for ExecWithOptions so it always returns error, should it be left in pod_command_executor?
Am I missing something here?
There was a problem hiding this comment.
Old code was returning error (or nil) as is, new code returns nil as is, and wraps an error with ExecError (which contains stderr/stdout tails), what is actually was the purpose of this PR.
Because without that change, only PodCommandExecutor users were able to find/parse an error in logs, and we want to give this possibility for users of kube.Exec/kube.ExecWithOptions/kube.ExecOutput too.
|
LGTM, we can merge after Prasad looks into the reply of his comment. |
PrasadG193
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR contains fix for #2066
From now, regardless the way of invocation, execution error will contain tail of stdout/stderr.
Which then could be used by the invoker to construct more precise error.
Pull request type
Please check the type of change your PR introduces:
Issues
kube.ExecandpodCommandExecutor.Execshould create theExecOptionssimilarly #2066Test Plan