Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common exec error handling #2501
Common exec error handling #2501
Changes from 4 commits
0afc932
b998a67
1e0dc7f
af8489a
291ee00
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that necessary here?
It seems like this will change the behaviour for
ExecWithOptions
so it always returns error, should it be left in pod_command_executor?Am I missing something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old code was returning error (or nil) as is, new code returns nil as is, and wraps an error with ExecError (which contains stderr/stdout tails), what is actually was the purpose of this PR.
Because without that change, only
PodCommandExecutor
users were able to find/parse an error in logs, and we want to give this possibility for users ofkube.Exec
/kube.ExecWithOptions
/kube.ExecOutput
too.