Upgrade k8s version to 0.29.x #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabhi
force-pushed
the
update-k8s-dependencies-0-28-x
branch
from
8b44b24
to
fde8d9f
Compare
mabhi
force-pushed
the
update-k8s-dependencies-0-28-x
branch
from
2746b72
to
28c0b8a
Compare
pavannd1
reviewed
Dec 22, 2023
pkg/controllers/repositoryserver/repositoryserver_controller_test.go
Outdated
Show resolved
Hide resolved
mabhi
force-pushed
the
update-k8s-dependencies-0-28-x
branch
from
c2cd70d
to
3b675f0
Compare
mabhi
force-pushed
the
update-k8s-dependencies-0-28-x
branch
2 times, most recently
from
a4032ed
to
f463367
Compare
mabhi
force-pushed
the
update-k8s-dependencies-0-28-x
branch
2 times, most recently
from
090931c
to
d4a084c
Compare
kale-amruta
reviewed
Feb 2, 2024
PrasadG193
reviewed
Feb 6, 2024
mabhi
force-pushed
the
update-k8s-dependencies-0-28-x
branch
from
d4a084c
to
a09e4cd
Compare
PrasadG193
reviewed
Feb 12, 2024
mabhi
force-pushed
the
update-k8s-dependencies-0-28-x
branch
from
7d5fcd1
to
7efa26f
Compare
viveksinghggits
approved these changes
Feb 13, 2024
| @@ -79,7 +81,7 @@ func main() { | |||
| config := ctrl.GetConfigOrDie() | |||
| mgr, err := ctrl.NewManager(config, ctrl.Options{ | |||
| Scheme: scheme, | |||
| MetricsBindAddress: metricsAddr, | |||
| Metrics: server.Options{BindAddress: metricsAddr}, | |||
There was a problem hiding this comment.
LGTM, can you check if the metrices are actually being exposed after this change.
mabhi
force-pushed
the
update-k8s-dependencies-0-28-x
branch
from
7efa26f
to
5e2e57f
Compare
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
…corev1.VolumeResourceRequirements Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
mabhi
force-pushed
the
update-k8s-dependencies-0-28-x
branch
from
5e2e57f
to
3501d84
Compare
mabhi
added a commit
that referenced
this pull request
Feb 20, 2024
mabhi
added a commit
that referenced
this pull request
Feb 22, 2024
mabhi
added a commit
that referenced
this pull request
Feb 23, 2024
mabhi
added a commit
that referenced
this pull request
Feb 23, 2024
mabhi
added a commit
that referenced
this pull request
Feb 28, 2024
mabhi
added a commit
that referenced
this pull request
Feb 28, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
* Revert "Revert "Upgrade k8s version to 0.29.x (#2532)" (#2676)" This reverts commit 5002a06. * Add webhook to controller manager Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io> * Updated validation webhook for blueprints Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io> * Rearrange imports Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io> * Revert webhook handler methods with nil pointer fix Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io> * Take logger out in utils, as used in multiple places Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io> * Addressed review comments Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io> * Revert "Take logger out in utils, as used in multiple places" This reverts commit ad7aeba. * Addressed review comments w.r.t controller-runtime setlogger and [nits] Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io> * Addressed review comments w.r.t controller-runtime setlogger and [nits] Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io> * Tidying go.mod Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io> --------- Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Upgrades various k8s-related dependencies
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan