-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8S version upgrade v0.29.x and related changes #2681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52e7e2d
to
05504a0
Compare
viveksinghggits
requested changes
Feb 23, 2024
05504a0
to
13a732b
Compare
pavannd1
reviewed
Feb 23, 2024
PrasadG193
reviewed
Feb 26, 2024
32bcd07
to
b6c01d3
Compare
PrasadG193
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
viveksinghggits
approved these changes
Feb 28, 2024
pavannd1
reviewed
Feb 28, 2024
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
This reverts commit ad7aeba.
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
14cab24
to
2ad9c58
Compare
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The following PR is the revert of previous reverted PR: #2676 .
This PR includes :
Without the second change there was always a chance that the mutating/validating webhook request never reached the controller
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Install kanister controller using private image in repo with local changes (TAG=v0.0.6)
helm upgrade --install kanister ./helm/kanister-operator --create-namespace -n kanister --set image.repository=mabhi2ic/controller --set image.tag=${TAG}
Check the correct version of the controller image with the changes
Testing by issuing a valid blueprint
Container logs for the above -
Testing issuing an invalid blueprint
Container logs for the above -