Tests optimizations #2567
Closed
Tests optimizations #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhum
requested review from
pavannd1,
PrasadG193,
viveksinghggits and
julio-lopez
hairyhum
force-pushed
the
ci-test-optimization
branch
2 times, most recently
from
58f094d
to
928eba3
Compare
hairyhum
force-pushed
the
ci-test-optimization
branch
3 times, most recently
from
38991d0
to
2770556
Compare
Parallel test suites are running in the same process, which makes them share env variables. Use mutex to block tests from running concurrently. Not the pretiest solution, but all others like build tags are quite tricky to apply right. Ideally we shouldn't rely on environment variables for this configuration.
Make it so controller namespace is checked only when needed Deprecate GetControllerServiceAccount
hairyhum
force-pushed
the
ci-test-optimization
branch
from
2770556
to
c57757e
Compare
|
This one is stale and will require some work to update all tests. Closing for now, can be a reference if we want to attempt to improve test performance in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Follow-up to #2534
NOTE: We currently use env variables to configure kanister and that prevents some tests from running in parallel. Currently using
testmutexmutex to block them.This is not ideal solution, but other options such as regex matching or build tags are just worse.
We could rework controller and API configuration so it doesn't rely on environment variables, which can potentially make it safer.
Pull request type
Please check the type of change your PR introduces:
Test Plan