Optimizations for main build workflow #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhum
force-pushed
the
ci-optimise-main-workflow
branch
6 times, most recently
from
ab17110
to
56c0593
Compare
hairyhum
force-pushed
the
ci-optimise-main-workflow
branch
4 times, most recently
from
be6d2a9
to
ace9491
Compare
hairyhum
changed the title
This was referenced Dec 15, 2023
hairyhum
force-pushed
the
ci-optimise-main-workflow
branch
from
ace9491
to
c37de85
Compare
denisvmedia
reviewed
Dec 21, 2023
viveksinghggits
approved these changes
Dec 21, 2023
Uploading/downloading the artifact takes longer than setting up deps in the test and build steps most of the time. Also remove double run of `go test` which left over from the time when test compilation was a separate command.
hairyhum
force-pushed
the
ci-optimise-main-workflow
branch
from
ab22d5c
to
055366f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Trying to reduce time it takes to run the CI workflow.
Currently packing and unpacking entire directory takes a long time. It's faster to just download the go dependencies.
Current changes:
lint,test,buildanddocssteps run in parallelgo testintest.sh, this was left over from the time when test build was separate from test run, no longer requiredThese changes do not include any caching proposed in #2352 but already cut the pipeline time more then 2 times so it make sense to merge that first and then work on caching as a follow-up
Pull request type
Please check the type of change your PR introduces:
Test Plan
Run the pipeline.