-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provisioned-by
annotations to PVs created by CreateVolumeFromSnapshot
kanister function
#2705
Conversation
LGTM. I'd approve but I don't recall whether that triggers merge on kanister or not. Your option on my feedback. Otherwise I approve and ask Pavan for +1. (I'm AFK all weekend). |
…/kanister into provby-pv-annotations
1167c35
to
0e45e63
Compare
@viveksinghggits are we waiting on any responses for this or is it ready to merge? |
this is not ready to merge. there were some other bugs that I figured out while working on this and those are being merged as part of once those are merged. We will be able to merge this. |
As soon as they are are merged I will add kueue to this. |
Change Overview
If PVs and PVCs are created by kanister using provider based provisioners and proper annotations are not set, when we delete the PVC, respective PV gets to
Failed
state and is not cleaned up. Because of that the volume in storage provider is not deleted. This happens because of the migration of provider based provisioner's migration to CSI based provisioners. And if proper annotation is not added provider based PVs are not deleted because CSI would not know what to do.This PR makes sure that when kanister creates the PV in
CreateVolumeFromSnapshot
kanister function, we add proper annotation so that when PVCs are deleted, PVs are released properly and deleted.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan