Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated zone and region label with new labels #2732

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

viveksinghggits
Copy link
Contributor

@viveksinghggits viveksinghggits commented Mar 8, 2024

Change Overview

While creating PV we set annotations to define the topology of the PV. The annotations that were being used are deprecated and this PR makes sure that we change them and use the new respective annotations.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E
kanister/pkg/function (use-correct-topology-labels*) » go test -check.f "CreateVolumeSnapshotTestSuite"                  
OK: 1 passed
PASS
ok  	github.com/kanisterio/kanister/pkg/function	39.246s


kanister/pkg/blockstorage/zone (use-correct-topology-labels*) » go test -check.f "ZoneSuite"
...
...
OK: 7 passed, 1 skipped
PASS
ok  	github.com/kanisterio/kanister/pkg/blockstorage/zone	30.058s

@infraq infraq added this to In Progress in Kanister Mar 8, 2024
@hairyhum
Copy link
Contributor

hairyhum commented Mar 8, 2024

A bunch of tests also use FDZoneLabelName. Should they be updated?

@viveksinghggits
Copy link
Contributor Author

A bunch of tests also use FDZoneLabelName. Should they be updated?

hmm, I noticed them and thought maybe the should be handled by another PR, but I can make that change in this PR itself.

@viveksinghggits
Copy link
Contributor Author

Hi @hairyhum ,
I have made the change. I have knowingly not changed all the occurrences to new label to make sure that we have handling for both deprecated as well as new label.

This commit makes sure that we are using correct topology labels in other
places of project as well. I have knowingly not changes some places to make
sure that we are able to handle the older label as well.
Kanister automation moved this from In Progress to Reviewer approved Mar 8, 2024
@mergify mergify bot merged commit a4ea10b into master Mar 8, 2024
14 checks passed
Kanister automation moved this from Reviewer approved to Done Mar 8, 2024
@mergify mergify bot deleted the use-correct-topology-labels branch March 8, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants