Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): tag kanisterio/build image as latest or dev_latest tag #2754

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

hairyhum
Copy link
Contributor

Change Overview

Currently we have to update the build image tag every time we build a new one. This is because we sometimes build "dev" versions of this image for testing.

Tagging 'latest' and 'dev_latest' makes it more convenient to use.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

Run the workflow to build dev_latest and latest tags.

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Currently we have to update the build image tag every time we build a new one.
This is because we sometimes build "dev" versions of this image for testing.

Tagging 'latest' and 'dev_latest' makes it more convenient to use.
@infraq infraq added this to In Progress in Kanister Mar 15, 2024
@@ -7,6 +7,14 @@ on:
description: 'Image tag in the format vx.x.x'
required: true
type: string
latest_tag:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this workflow is run automatically right?
how would someone decide if they want to tag the image to latest or something else?

Copy link
Contributor Author

@hairyhum hairyhum Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this pipeline does not run automatically. workflow_dispatch trigger can only be triggered manually and the inputs have to be set by the person triggering it.

  • dev_latest should be set when building the test image (e.g. to test changes in the image)
  • latest should be set when building the image to be used for downstream users, such as run_container.sh and CI pipelines

I did not change the run_container.sh in this PR because we don't have any latest image yet.

@viveksinghggits
Copy link
Contributor

viveksinghggits commented Mar 19, 2024

PR looks good, but just for my understanding, if we talk about below from PR desc

Currently we have to update the build image tag every time we build a new one.

where do we update the image tag? are you talking about updating it in the Makefile, if that is he case is that not required after this PR?

@hairyhum
Copy link
Contributor Author

where do we update the image tag? are you talking about updating it in the Makefile, if that is he case is that not required after this PR?

@viveksinghggits it needs to be updated in run_container.sh and in the release pipeline (currently not in this repo). We don't always do that and that can randomly cause pipelines to fail if we forget.

Kanister automation moved this from In Progress to Reviewer approved Mar 20, 2024
@hairyhum hairyhum merged commit 35043cf into master Mar 20, 2024
12 checks passed
Kanister automation moved this from Reviewer approved to Done Mar 20, 2024
@hairyhum hairyhum deleted the build-image-latest-tag branch March 20, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants