Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ci): tag kanisterio/build image as latest or dev_latest tag #2754

Merged
merged 3 commits into from
Mar 20, 2024
Merged

build(ci): tag kanisterio/build image as latest or dev_latest tag #2754

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f8154e
build(ci): tag kanisterio/build image as latest or dev_latest tag
hairyhum Mar 15, 2024
b5ed69e
Merge branch 'master' into build-image-latest-tag
hairyhum Mar 20, 2024
da69fb7
Merge branch 'master' into build-image-latest-tag
hairyhum Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/kanister-image-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ on:
description: 'Image tag in the format vx.x.x'
required: true
type: string
latest_tag:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this workflow is run automatically right?
how would someone decide if they want to tag the image to latest or something else?

Copy link
Contributor Author

@hairyhum hairyhum Mar 18, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this pipeline does not run automatically. workflow_dispatch trigger can only be triggered manually and the inputs have to be set by the person triggering it.

  • dev_latest should be set when building the test image (e.g. to test changes in the image)
  • latest should be set when building the image to be used for downstream users, such as run_container.sh and CI pipelines

I did not change the run_container.sh in this PR because we don't have any latest image yet.

description: 'Tag image as latest or dev_latest'
required: true
default: dev_latest
type: choice
options:
- latest
- dev_latest

env:
REGISTRY: ghcr.io
Expand Down Expand Up @@ -52,6 +60,7 @@ jobs:
type=sha
{{date 'YYYY.MM.DD-HHmm'}}
${{ inputs.tag }}
${{ inputs.latest_tag }}
- name: Login to GHCR
uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0
with:
Expand Down