-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(release): add pre-release workflow to create version bump PR #2774
Conversation
Added RELEASE.md with kanister release instructions. It currently describes the process with reno release notes, which are not merged yet. |
3826b05
to
7468b5e
Compare
Rebased it on |
a05289f
to
218972c
Compare
a9a39cf
to
667d785
Compare
275e217
to
79ff7b7
Compare
667d785
to
9ca0fec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PRERELEASE_DOCS_BRANCH: 'dg8d45z' | ||
|
||
jobs: | ||
## TODO we can add a condition like github.actor.role == 'Maintainer' to limit trigger to maintainers only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we do this as part of this PR itself? I think we should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not yet supported, but there's active discussion ongoing. When it's implemented, we can do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Overview
Currently release process is happening outside of github workflows. This is a first step to move it there.
Pre-release workflow can be run from workflow dispatch in github actions and will create a PR with version update.
I've also changed the version bump PR title because it's not only updating docs
Pull request type
Please check the type of change your PR introduces:
Test Plan
Test runs can be found in https://github.com/kanisterio/kanister/actions/workflows/pre-release.yml