Add support for --dry-run in Helm Client #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
mabhi
reviewed
May 2, 2024
There was a problem hiding this comment.
@r4rajat can you please write a test that would use these utilities to install Kanister by specifying a helm field and make sure that the rendered output has respective change.
If you want to do that as part of another PR that is also ok, in that case can you document in the PR description how exactly/which method calls are involved to write that test.
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
10 tasks
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
viveksinghggits
requested changes
May 10, 2024
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
pkg/helm/client.go
Outdated
| // Install installs helm chart with given release name. | ||
| // The output string is to check the generated manifests of a release without installing the chart when ‘dryRun’ flags combined. | ||
| // For normal installation, this output string is blank. | ||
| func (h CliClient) Install(ctx context.Context, chart, version, release, namespace string, values map[string]string, wait, dryRun bool) (string, error) { |
There was a problem hiding this comment.
Suggested change
| func (h CliClient) Install(ctx context.Context, chart, version, release, namespace string, values map[string]string, wait, dryRun bool) (string, error) { | |
| func (h CliClient) Install( | |
| ctx context.Context, | |
| chart, | |
| version, | |
| release, | |
| namespace string, | |
| values map[string]string, | |
| wait, | |
| dryRun bool) (string, error) { |
There was a problem hiding this comment.
I was thinking if there should be a type InstallOptions that would have all these fields. But we can do that later as well.
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
viveksinghggits
approved these changes
May 20, 2024
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Add support for --dry-run in Helm Client for better debugging
Pull request type
Please check the type of change your PR introduces:
Issues
helm installutility accept--dry-run#2796Test Plan