Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Helm Test to cover additional attributes introduced in values.yaml used during kanister operator installation #2881

Merged
merged 38 commits into from
May 20, 2024
Merged

Add Helm Test to cover additional attributes introduced in values.yaml used during kanister operator installation #2881

merged 38 commits into from
May 20, 2024

Conversation

mabhi
Copy link
Contributor

@mabhi mabhi commented May 10, 2024 •
edited
Loading

Change Overview

Now that support has been added PR for tolerations and nodeSelector in the kanister helm chart, they need to be tested via helm-tests.
With additional support for dry-run with PR we can run helm install dry run on these charts and rendered output can be validated.
This PR specifically does the above requirement by adding helm tests to validate the properties are populated with the provided helm values.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

r4rajat and others added 8 commits April 16, 2024 22:41
@r4rajat
Add support for --dry-run in Helm Client
7709520 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
refactor app installs to set dryRun as false
8b0b5a8 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Add support for send output of helm install with dryRun enabled
40c7053 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Add Helper Functions for Helm Installation Output
1d2dcc1 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Merge branch 'master' into add-supprt-for-dry-run-helm-client
4d196e0
@mabhi
Address review comments
c5f8228 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi
Address lint error
9b30899 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi
Initial commit
672fcac 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi mabhi marked this pull request as draft May 10, 2024 08:22
@mabhi
Fixed test cases failures
bef7b7a 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi mabhi marked this pull request as ready for review May 10, 2024 09:15
@mabhi mabhi marked this pull request as draft May 10, 2024 10:01
@mabhi mabhi marked this pull request as ready for review May 10, 2024 10:03
@mabhi mabhi requested a review from viveksinghggits May 10, 2024 10:03
mabhi added 2 commits May 10, 2024 16:11
@mabhi
Address review comments
7fb14d5 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi
Merge branch 'add-supprt-for-dry-run-helm-client' into add-helm-test-…
2b11b89 
…support-pr-2791
@viveksinghggits
Copy link
Contributor

@mabhi can you please correct the title of the PR.

@mabhi mabhi changed the title Initial commit Add helm test support for nodeselector and tolerations attribute in deployment with helm May 10, 2024
viveksinghggits
viveksinghggits requested changes May 10, 2024
View reviewed changes
pkg/testing/helm/helm_test.go Outdated Show resolved Hide resolved
pkg/testing/helm/helm_test.go Outdated Show resolved Hide resolved
@mabhi mabhi changed the title Add helm test support for nodeselector and tolerations attribute in deployment with helm Add additional Helm Test support for kanister operator installation May 10, 2024
mabhi added 2 commits May 10, 2024 22:50
@mabhi
Address review comments
4fe93c4 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi
Added [nit]
5753a0d 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi mabhi changed the title Add additional Helm Test support for kanister operator installation Add additional Helm Test for kanister operator installation May 10, 2024
@mabhi mabhi changed the title Add additional Helm Test for kanister operator installation Add Helm Test for additional attributes in values.yaml used during kanister operator installation May 10, 2024
@mabhi mabhi changed the title Add Helm Test for additional attributes in values.yaml used during kanister operator installation Add Helm Test to cover additional attributes introduced in values.yaml used during kanister operator installation May 11, 2024
mabhi added 2 commits May 11, 2024 10:19
@mabhi
Merge branch 'add-supprt-for-dry-run-helm-client' into add-helm-test-…
eba1990 
…support-pr-2791
@mabhi
Address comments
594202a 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi mabhi requested a review from viveksinghggits May 11, 2024 04:54
mabhi added 2 commits May 16, 2024 18:33
viveksinghggits
viveksinghggits reviewed May 16, 2024
View reviewed changes
pkg/helm/helm_helpers.go Outdated Show resolved Hide resolved
pkg/helm/helm_helpers.go Outdated Show resolved Hide resolved
pkg/helm/helm_helpers.go Outdated Show resolved Hide resolved
pkg/helm/helm_helpers.go Outdated Show resolved Hide resolved
pkg/helm/helm_helpers.go Outdated Show resolved Hide resolved
pkg/helm/helm_helpers.go Outdated Show resolved Hide resolved
pkg/helm/helm_helpers.go Outdated Show resolved Hide resolved
mabhi added 3 commits May 16, 2024 22:47
@mabhi
Address refactoring review comments
ab760d9 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi
Merge branch 'add-supprt-for-dry-run-helm-client' into add-helm-test-…
dd907d7 
…support-pr-2791
@mabhi
Address review comments
29a0a24 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi mabhi requested a review from viveksinghggits May 16, 2024 17:29
viveksinghggits
viveksinghggits reviewed May 17, 2024
View reviewed changes
pkg/testing/helm/helm_test.go Outdated Show resolved Hide resolved
pkg/testing/helm/helm_test.go Outdated Show resolved Hide resolved
pkg/testing/helm/helm_test.go Outdated Show resolved Hide resolved
pkg/testing/helm/helm_test.go Outdated Show resolved Hide resolved
mabhi added 6 commits May 17, 2024 20:00
@mabhi
Updated doc comments and removed unnecessary comments
68759c9 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi
Merge branch 'add-supprt-for-dry-run-helm-client' into add-helm-test-…
41381b2 
…support-pr-2791
@mabhi
Merge branch 'master' into add-supprt-for-dry-run-helm-client
d8643b9
@mabhi
Minor refactor
5a2f53c 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi
Merge branch 'add-supprt-for-dry-run-helm-client' into add-helm-test-…
9dd2f2a 
…support-pr-2791
@mabhi
Address review comments
aebe4e6 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi mabhi requested a review from viveksinghggits May 17, 2024 15:06
mabhi added 5 commits May 17, 2024 20:55
@mabhi
Updated test comparison
81e29ad 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi
Shortened func comments
dff1314 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi
Addressed review comments
f6e5d1c 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi
Merge branch 'add-supprt-for-dry-run-helm-client' into add-helm-test-…
09af8e7 
…support-pr-2791
@mabhi
Update helm helper func name and usages
ababf2c 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
mabhi added 2 commits May 20, 2024 19:00
@mabhi
Addressed review comment
afe354a 
Signed-off-by: Abhijit Mukherjee <abhijit.mukherjee@infracloud.io>
@mabhi
Merge branch 'add-supprt-for-dry-run-helm-client' into add-helm-test-…
8831a70 
…support-pr-2791
Base automatically changed from add-supprt-for-dry-run-helm-client to master May 20, 2024 14:01
@mabhi mabhi added the kueue label May 20, 2024
@mergify mergify bot merged commit c9c8ea2 into master May 20, 2024
15 checks passed
@mergify mergify bot deleted the add-helm-test-support-pr-2791 branch May 20, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mabhi @viveksinghggits @r4rajat