-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for aws rds postgres integration with Kanister #334
Conversation
9e8764a
to
c4750cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but please fix the licensing. We should remove the apache license and add our copyright to every file and append to the kubernetes copyrights.
|
||
aws rds wait db-instance-available --db-instance-identifier=test-postgresql-instance | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PrasadG193 @tdmanv - I'm wondering if we can simplify this top level README. The only requirement for someone to test this out should be:
- Create a new RDS instance or have instanceID/host info available for an existing instance
- Create a ConfigMap with this info
- Create a Blueprint
- Run backup/restore commands
The pgtest app is useful for testing but complicates this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't that confuse users? They may not get the context behind why do they need configmap and which configmap to use/update.
In current PR we can add a note suggesting instead of pgtest app, they can use their own application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users in this example likely already have an application that is using an RDS DB and pgtest on the top level will be confusing.
What will be most useful for them will be to know how they can use this example blueprint with their DB instance.
I think the pgtest example is useful but perhaps this detailed README.md is in a sub-folder and the top level is very minimal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4baf795
to
e5c8348
Compare
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
b03d2b0
to
3430d1c
Compare
Change Overview
This PR adds an example to demonstrate Kanister integration with AWS RDS PostgreSQL engine
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan