fix: filter browser logging by level of LOG

Additional fix to the bug, "filter browser logging by level" ([35965d9](35965d9)), closes [#2228](#2228) Otherwise console.log ignore doesn't work with ``` browserConsoleLogOptions: { level: 'debug', terminal: true } ```
karma-runner · Feb 19, 2017 · 89a7a1c · 89a7a1c · nello · Feb 23, 2017
1 parent eaeffe9
commit 89a7a1c
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 4 deletions.
diff --git a/lib/constants.js b/lib/constants.js
@@ -15,13 +15,14 @@ exports.LOG_ERROR = 'ERROR'
 exports.LOG_WARN = 'WARN'
 exports.LOG_INFO = 'INFO'
 exports.LOG_DEBUG = 'DEBUG'
+exports.LOG_LOG = 'LOG'
 exports.LOG_PRIORITIES = [
   exports.LOG_DISABLE,
   exports.LOG_ERROR,
   exports.LOG_WARN,
   exports.LOG_INFO,
   exports.LOG_DEBUG,
-  exports.LOG_DISABLE
+  exports.LOG_LOG
 ]
 
 // Default patterns for the pattern layout.

diff --git a/test/e2e/browser_console.feature b/test/e2e/browser_console.feature
@@ -11,7 +11,10 @@ Feature: Browser Console Configuration
       plugins = [
         'karma-jasmine',
         'karma-phantomjs-launcher'
-      ];
+      ],
+      browserConsoleLogOptions = {
+        level: 'log'
+      };
       """
     When I start Karma
     Then it passes with like:

diff --git a/test/unit/reporters/base.spec.js b/test/unit/reporters/base.spec.js
@@ -83,9 +83,45 @@ describe('reporter', function () {
       return expect(writeSpy).to.have.been.calledWith('LOG: Message\n')
     })
 
-    it('should not log if lower priority than browserConsoleLogOptions.level', function () {
+    it('should not log if lower priority than browserConsoleLogOptions "error"', function () {
       var reporter = new m.BaseReporter(null, null, true, {
-        browserConsoleLogOptions: {level: 'ERROR'}
+        browserConsoleLogOptions: {level: 'error'}
+      }, adapter)
+      var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
+
+      reporter._browsers = ['Chrome']
+      reporter.onBrowserLog('Chrome', 'Message', 'WARN')
+
+      return writeSpy.should.have.not.been.called
+    })
+
+    it('should not log if lower priority than browserConsoleLogOptions "warn"', function () {
+      var reporter = new m.BaseReporter(null, null, true, {
+        browserConsoleLogOptions: {level: 'warn'}
+      }, adapter)
+      var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
+
+      reporter._browsers = ['Chrome']
+      reporter.onBrowserLog('Chrome', 'Message', 'INFO')
+
+      return writeSpy.should.have.not.been.called
+    })
+
+    it('should not log if lower priority than browserConsoleLogOptions "info"', function () {
+      var reporter = new m.BaseReporter(null, null, true, {
+        browserConsoleLogOptions: {level: 'info'}
+      }, adapter)
+      var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
+
+      reporter._browsers = ['Chrome']
+      reporter.onBrowserLog('Chrome', 'Message', 'DEBUG')
+
+      return writeSpy.should.have.not.been.called
+    })
+
+    it('should not log if lower priority than browserConsoleLogOptions "debug"', function () {
+      var reporter = new m.BaseReporter(null, null, true, {
+        browserConsoleLogOptions: {level: 'debug'}
       }, adapter)
       var writeSpy = sinon.spy(reporter, 'writeCommonMsg')