fix(reporters): Revert the backwards-incompatible log priority order changes #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests ensuring a lower priority doesn't get logged were written in an incorrect format so even changing the order in the LOG_PRIORITIES array would not make them fail.
…changes Commit 35965d9 changed the order of log priorities, making lots of configurations no longer print console.log messages. This was a backwards-incompatible change which this commit reverts. Tests were added to ensure the proper order is respected. Fixes karma-runner#2582
mgol
referenced
this pull request
Apr 26, 2017
|
according to Mozilla this is the right place for LOG, but people misuse it |
|
@blackswanny Regardless what's the correct way spec-wise this was a breaking change which shouldn't happen before 2.0. This PR restores backwards compatibility. |
|
Thank you @maksimr |
|
@dignifiedquire could you release a new version to npm? |
|
yeah sorry will do today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 35965d9 changed the order of log priorities, making lots of
configurations no longer print console.log messages. This was a
backwards-incompatible change which this commit reverts.
Tests were added to ensure the proper order is respected.
Fixes #2582
Also, another commit in this PR:
test(reporters): Fix the log suppressing tests
The tests ensuring a lower priority doesn't get logged were written in an
incorrect format so even changing the order in the LOG_PRIORITIES array
would not make them fail.