Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter browser logging by level of LOG #2540

Merged
merged 7 commits into from
Feb 19, 2017

Conversation

blackswanny
Copy link
Contributor

Additional fix to the next bug:
filter browser logging by level (35965d9), closes #2228
otherwise console.log ignore doesn't work with

browserConsoleLogOptions: {
        level: 'debug',
        terminal: true
    }

Additional fix to the next bug:
filter browser logging by level  ([35965d9](karma-runner@35965d9)), closes [karma-runner#2228](karma-runner#2228)
otherwise console.log ignore doesn't work with 
    browserConsoleLogOptions: {
        level: 'debug',
        terminal: true
    }
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@blackswanny
Copy link
Contributor Author

blackswanny commented Jan 17, 2017 via email

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, could you please add an integration test, which is failing without this change, but pases with it?

@blackswanny
Copy link
Contributor Author

sorry, I am trying to add functionality to fix integration tests, however "npm run test:integration" fails on my machine, cause non of the browsers is seen by karma while it tries to launch them. So I can't debug and understand why it is failing

@blackswanny
Copy link
Contributor Author

@dignifiedquire ok, all fixed, except codeclimate. How to fix it? no debug information. Grunt lint doesn't show anything

@dignifiedquire
Copy link
Member

Thank you, this looks good to me. @wesleycho could take a look please as well you worked on the other PR for the logging fix.

@blackswanny
Copy link
Contributor Author

@wesleycho can you review?

@blackswanny
Copy link
Contributor Author

@wesleycho please, review. My work is pending on this change

Copy link
Member

@wesleycho wesleycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dignifiedquire dignifiedquire merged commit 89a7a1c into karma-runner:master Feb 19, 2017
@dignifiedquire
Copy link
Member

Thank you :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browserConsoleLogOptions does not filter console by level
4 participants