-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter browser logging by level of LOG #2540
Conversation
Additional fix to the next bug: filter browser logging by level ([35965d9](karma-runner@35965d9)), closes [karma-runner#2228](karma-runner#2228) otherwise console.log ignore doesn't work with browserConsoleLogOptions: { level: 'debug', terminal: true }
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it!
From: googlebot <notifications@github.com>
Reply-To: karma-runner/karma <reply@reply.github.com>
Date: Tuesday, January 17, 2017 at 3:14 PM
To: karma-runner/karma <karma@noreply.github.com>
Cc: Oleg Gomozov <blackswanny@gmail.com>, Author <author@noreply.github.com>
Subject: Re: [karma-runner/karma] filter browser logging by level of LOG (#2540)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.
—You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/karma-runner/karma","title":"karma-runner/karma","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/karma-runner/karma"}},"updates":{"snippets":[{"icon":"PERSON","message":"@googlebot in #2540: Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\n:memo: **Please visit \u003chttps://cla.developers.google.com/\u003e to sign.**\n\nOnce you've signed, please reply here (e.g. `I signed it!`) and we'll verify. Thanks.\n\n---\n\n- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).\n- If you signed the CLA as a corporation, please let us know the company's name.\n\n\u003c!-- need_sender_cla --\u003e"}],"action":{"name":"View Pull Request","url":"#2540 (comment)"}}}
|
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, could you please add an integration test, which is failing without this change, but pases with it?
sorry, I am trying to add functionality to fix integration tests, however "npm run test:integration" fails on my machine, cause non of the browsers is seen by karma while it tries to launch them. So I can't debug and understand why it is failing |
@dignifiedquire ok, all fixed, except codeclimate. How to fix it? no debug information. Grunt lint doesn't show anything |
Thank you, this looks good to me. @wesleycho could take a look please as well you worked on the other PR for the logging fix. |
@wesleycho can you review? |
@wesleycho please, review. My work is pending on this change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you |
Additional fix to the next bug:
filter browser logging by level (35965d9), closes #2228
otherwise
console.log
ignore doesn't work with