Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DataTable Component #27

Open
wants to merge 1 commit into
base: ng-dashboard-react
Choose a base branch
from

Conversation

ShwetKhatri2001
Copy link

@ShwetKhatri2001 ShwetKhatri2001 commented Aug 28, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
The PR includes a reusable Table component to be used on different pages with different types of data.
This is the first iteration of the component. It will be modified further with API integration and required functionalities working.
It is static and currently implementing this Figma Design ( Overview Page - iteration 7 frame ).

Which issue(s) this PR fixes:
It's a general component useful for different pages of the entire application.

Special notes for your reviewer:
@RainbowMango I'm attaching the screenshot of the developed UI, which was taken by using the component on a new page just for testing. Although, it is not used in any of the pages currently. So, the PR is just having its implementation.

karmada table component

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: @ShwetKhatri2001

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 28, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot
Copy link
Collaborator

Welcome @ShwetKhatri2001! It looks like this is your first PR to karmada-io/dashboard 🎉

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2022
Signed-off-by: ShwetKhatri2001 <19dcs001@lnmiit.ac.in>
@RainbowMango
Copy link
Member

Seems it's a static page now, I can't tell if works as expected, I guess we'd better build a real page with it.

@ShwetKhatri2001
Copy link
Author

I need some resources to understand the API response. So that I can make the component dynamic with the actual data.

@RainbowMango
Copy link
Member

What kind of resources do you need?

@ada2468
Copy link

ada2468 commented Aug 30, 2022

@ShwetKhatri2001
Check out this file. I'm using this one as API design spec.
https://github.com/karmada-io/karmada/blob/master/api/openapi-spec/swagger.json

@ShwetKhatri2001
Copy link
Author

@ada2468 Thanks for the help, but we will have different types of data passed to this component and the pages where the component is going to be used are not developed/merged yet. so, the component can't be completely dynamic or finalized currently according to me. @RainbowMango what's your thought on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants