-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DataTable Component #27
base: ng-dashboard-react
Are you sure you want to change the base?
Added DataTable Component #27
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @ShwetKhatri2001! It looks like this is your first PR to karmada-io/dashboard 🎉 |
Signed-off-by: ShwetKhatri2001 <19dcs001@lnmiit.ac.in>
6dd1219
to
8965369
Compare
Seems it's a |
I need some resources to understand the API response. So that I can make the component dynamic with the actual data. |
What kind of resources do you need? |
@ShwetKhatri2001 |
@ada2468 Thanks for the help, but we will have different types of data passed to this component and the pages where the component is going to be used are not developed/merged yet. so, the component can't be completely dynamic or finalized currently according to me. @RainbowMango what's your thought on this? |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The PR includes a reusable Table component to be used on different pages with different types of data.
This is the first iteration of the component. It will be modified further with API integration and required functionalities working.
It is static and currently implementing this Figma Design ( Overview Page - iteration 7 frame ).
Which issue(s) this PR fixes:
It's a general component useful for different pages of the entire application.
Special notes for your reviewer:
@RainbowMango I'm attaching the screenshot of the developed UI, which was taken by using the component on a new page just for testing. Although, it is not used in any of the pages currently. So, the PR is just having its implementation.
Does this PR introduce a user-facing change?:
Signed-off-by: @ShwetKhatri2001