-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lfx] Develop Override policy, Resource Binding, Work Page #29
base: ng-dashboard-react
Are you sure you want to change the base?
[lfx] Develop Override policy, Resource Binding, Work Page #29
Conversation
Signed-off-by: Jun Xiang <jx2161@nyu.edu>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@RainbowMango @chinmaym07 |
Does this demo base on static data? |
@RainbowMango |
I mean, we should get the data from |
Signed-off-by: Jun Xiang <jx2161@nyu.edu>
Signed-off-by: Jun Xiang <jx2161@nyu.edu>
@RainbowMango demo: Here is the example .yaml file I use to define the Override Policy in my Karmada during demo: apiVersion: policy.karmada.io/v1alpha1
kind: OverridePolicy
metadata:
name: example-override
namespace: default
spec:
resourceSelectors:
- apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
name: podinfo
overrideRules:
- targetCluster:
clusterNames:
- member1
overriders:
plaintext:
- path: "/spec/values"
operator: add
value:
replicaCount: 2 and the resource template .yaml: apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: HelmRepository
metadata:
name: podinfo
spec:
interval: 1m
url: https://stefanprodan.github.io/podinfo
---
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
name: podinfo
spec:
interval: 5m
chart:
spec:
chart: podinfo
version: 5.0.3
sourceRef:
kind: HelmRepository
name: podinfo |
@RainbowMango @chinmaym07 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work done so far @ada2468 .. 🔥 💯
Demo looks good to me.
Tree view is great. But it's currently breaking the design. Also some components are not as per the designs.
We will have to look for other ways to show the data.
Once we have the CRUD
functionality in place, can we include Json editor view as well as yaml file editor like we have in kubernetes dashboard.?
What other features can we add to our karmada dashboard to enhance it from UI as well as UX perspective ?
@chinmaym07 Other features can include search bar and filtering bar. They are already built-in in MUI Datagrid, I just need to correctly configure them. Also I can write some shell script to automate the deployment process. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
How to run this PR locally?
Special notes for your reviewer:
TEST mode: a dev feature for easier debugging program locally.
This mode allows user to generate some mock data based on the go-server API spec file, karmada/master/api/openapi-spec/swagger.json. The test mode bypass the authentication token check and allow you to go to preview the pages populated with mock data.
To enable testing mode, go to root folder, find .env file, and change "REACT_APP_STAGE=DEV" to "REACT_APP_STAGE=TEST". Use uppercase! To exist TEST mode, just change that field back to "DEV".
The testing script generates five sets of response data, each for the following API path:
/apis/policy.karmada.io/v1alpha1/overridepolicies
/apis/policy.karmada.io/v1alpha1/clusteroverridepolicies
/apis/work.karmada.io/v1alpha2/resourcebindings
/apis/work.karmada.io/v1alpha2/clusterresourcebindings
/apis/work.karmada.io/v1alpha1/works
, in accordance with pages:
Override Policy
Cluster Override Policy
Resource Binding
Cluster Resource Binding
Works.
demo:
https://raw.githubusercontent.com/AdaTempImg/temp1/main/LFX%20demo.gif
Signed-off-by: Jun Xiang jx2161@nyu.edu