Merge pull request #3766 from RuliXu/automated-cherry-pick-of-#3739-u…

…pstream-release-1.6 Automated cherry pick of #3739: fix: when application failover is enabled but propagateDeps
karmada-io · Jul 5, 2023 · fdc7ac6 · fdc7ac6
2 parents c31e161 + 7424a0f
commit fdc7ac6
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/util/validation/validation.go b/pkg/util/validation/validation.go
@@ -22,6 +22,9 @@ const LabelValueMaxLength int = 63
 func ValidatePropagationSpec(spec policyv1alpha1.PropagationSpec) field.ErrorList {
 	var allErrs field.ErrorList
 	allErrs = append(allErrs, ValidatePlacement(spec.Placement, field.NewPath("spec").Child("placement"))...)
+	if spec.Failover != nil && spec.Failover.Application != nil && !spec.PropagateDeps {
+		allErrs = append(allErrs, field.Invalid(field.NewPath("spec").Child("propagateDeps"), spec.PropagateDeps, "application failover is set, propagateDeps must be true"))
+	}
 	allErrs = append(allErrs, ValidateFailover(spec.Failover, field.NewPath("spec").Child("failover"))...)
 	return allErrs
 }