-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #3739: fix: when application failover is enabled but propagateDeps #3766
Automated cherry pick of #3739: fix: when application failover is enabled but propagateDeps #3766
Conversation
… false, the failover has no effect. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## release-1.6 #3766 +/- ##
============================================
Coverage 55.20% 55.20%
============================================
Files 221 221
Lines 20831 20834 +3
============================================
+ Hits 11499 11501 +2
Misses 8721 8721
- Partials 611 612 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please copy the release notes from the origin PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Leave LGTM to @chaunceyjiang for final decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaunceyjiang, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #3739 on release-1.6.
#3739: fix: when application failover is enabled but propagateDeps
For details on the cherry pick process, see the cherry pick requests page.