Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3739: fix: when application failover is enabled but propagateDeps #3766

Conversation

RuliXu
Copy link
Contributor

@RuliXu RuliXu commented Jul 5, 2023

Cherry pick of #3739 on release-1.6.
#3739: fix: when application failover is enabled but propagateDeps
For details on the cherry pick process, see the cherry pick requests page.

`karmada-webhook`: When application failover is enabled, users are prevented from setting propagateDeps to `false`.

… false, the failover has no effect.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3766 (7424a0f) into release-1.6 (c31e161) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           release-1.6    #3766   +/-   ##
============================================
  Coverage        55.20%   55.20%           
============================================
  Files              221      221           
  Lines            20831    20834    +3     
============================================
+ Hits             11499    11501    +2     
  Misses            8721     8721           
- Partials           611      612    +1     
Flag Coverage Δ
unittests 55.20% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/validation/validation.go 82.68% <0.00%> (-1.41%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please copy the release notes from the origin PR.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Leave LGTM to @chaunceyjiang for final decision.

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@RainbowMango RainbowMango mentioned this pull request Jul 3, 2023
3 tasks
Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit fdc7ac6 into karmada-io:release-1.6 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants