Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubenetes dependencies to v1.26.1 #3080

Merged
merged 6 commits into from
Feb 1, 2023

Conversation

RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Jan 29, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates Kubenetest dependencies to v1.26.1:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Karmada is now built with Kubernetes v1.26.1 dependencies.

Update controller-runtime to 0.14.2
Update cluster-api to latest commit

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango RainbowMango added this to the v1.5 milestone Jan 29, 2023
@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 29, 2023
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 29, 2023
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Merging #3080 (6865fd5) into master (2e34efc) will increase coverage by 0.28%.
The diff coverage is 40.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
+ Coverage   43.30%   43.58%   +0.28%     
==========================================
  Files         208      208              
  Lines       19429    19468      +39     
==========================================
+ Hits         8414     8486      +72     
+ Misses      10550    10501      -49     
- Partials      465      481      +16     
Flag Coverage Δ
unittests 43.58% <40.29%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/controllers/status/cluster_status_controller.go 0.00% <0.00%> (ø)
pkg/descheduler/descheduler.go 22.54% <0.00%> (-0.34%) ⬇️
pkg/util/lifted/validateclustertaints.go 0.00% <0.00%> (ø)
pkg/search/proxy/controller.go 79.75% <20.00%> (-4.22%) ⬇️
pkg/estimator/server/eventhandlers.go 21.00% <25.00%> (-1.12%) ⬇️
pkg/scheduler/event_handler.go 24.20% <25.00%> (-3.07%) ⬇️
pkg/controllers/context/context.go 48.57% <50.00%> (ø)
...urceinterpreter/defaultinterpreter/dependencies.go 38.12% <100.00%> (ø)
pkg/util/binding.go 100.00% <100.00%> (ø)
pkg/util/helper/binding.go 72.33% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RainbowMango RainbowMango force-pushed the pr_update_k8s branch 2 times, most recently from 622a781 to 6865fd5 Compare January 30, 2023 12:15
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango RainbowMango marked this pull request as ready for review January 31, 2023 03:09
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2023
@RainbowMango
Copy link
Member Author

I grouped the changes by commits, could you guys help to take a look?

This PR also adopts generic sets and fixed some static check warnings(I don't know why they become block warnings...)

@Garrybest
Copy link
Member

Sure.

/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XiShanYongYe-Chang for the IngressStatus part

LGMT

@Garrybest
Copy link
Member

@Garrybest for the lease controller part

LGTM

@RainbowMango
Copy link
Member Author

I verified the describe function locally, looks good:

-bash-5.0# _output/bin/linux/amd64/karmadactl version
karmadactl version: version.Info{GitVersion:"v1.4.0-196-ga1e8f164", GitCommit:"a1e8f164cb249659be25de1fdde37f33ede92f46", GitTreeState:"clean", BuildDate:"2023-02-01T03:26:42Z", GoVersion:"go1.19.3", Compiler:"gc", Platform:"linux/am}

-bash-5.0# _output/bin/linux/amd64/karmadactl describe deployments/nginx -C=member1
Name:                   nginx
Namespace:              default
CreationTimestamp:      Wed, 01 Feb 2023 11:29:04 +0800
Labels:                 app=nginx
                        propagationpolicy.karmada.io/name=nginx-propagation
                        propagationpolicy.karmada.io/namespace=default
                        resourcebinding.karmada.io/key=687f7fb96f
                        work.karmada.io/name=nginx-687f7fb96f
                        work.karmada.io/namespace=karmada-es-member1

@lonelyCZ If you find anything that needs to be fixed, please send a new PR.

@RainbowMango RainbowMango added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 1, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 43c1a8c into karmada-io:master Feb 1, 2023
@RainbowMango RainbowMango deleted the pr_update_k8s branch February 1, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants