Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cluster-api version to semantic version #3502

Merged
merged 1 commit into from
May 8, 2023

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates sigs.k8s.io/cluster-api from pseudo version v1.3.0-rc.0.0.20230127161026-14ffcb25bbf2 to the official version v1.4.0.

The pseudo version was introduced when updating Kubernetes dependencies at #3080, we have to wait for sigs.k8s.io/cluster-api@v1.4.0, see kubernetes-sigs/cluster-api#7906 (comment) for more details.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@XiShanYongYe-Chang
The v1alpha3 and v1alpha4 were deprecated at cluster-api@v1.4.0, we might need to do some migration work. (Not urgent).

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 8, 2023
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3502 (07f8929) into master (cda6a30) will increase coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3502      +/-   ##
==========================================
+ Coverage   52.65%   52.67%   +0.01%     
==========================================
  Files         213      213              
  Lines       19588    19588              
==========================================
+ Hits        10314    10317       +3     
+ Misses       8721     8719       -2     
+ Partials      553      552       -1     
Flag Coverage Δ
unittests 52.67% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@XiShanYongYe-Chang
Copy link
Member

The v1alpha3 and v1alpha4 were deprecated at cluster-api@v1.4.0, we might need to do some migration work. (Not urgent).

ok, I have created an issue for this work. I'll do this job when I have some time.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2023
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 012dd6f into karmada-io:master May 8, 2023
@RainbowMango RainbowMango deleted the pr_update_clusterapi branch March 30, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants