Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3496: fix When EnableEmptyWorkloadPropagation flag is false zero #3642

Conversation

chaunceyjiang
Copy link
Member

@chaunceyjiang chaunceyjiang commented Jun 6, 2023

Cherry pick of #3496 on release-1.4.
#3496: fix When EnableEmptyWorkloadPropagation flag is false zero
For details on the cherry pick process, see the cherry pick requests page.

`karmada-scheduler`: Fixed the issue that empty deployment can still be propagated to member clusters even when `--enableEmptyWorkloadPropagation` flag is false.

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 6, 2023
… still can be propagated to member cluster

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang chaunceyjiang force-pushed the automated-cherry-pick-of-#3496-origin-release-1.4 branch from 6c09f5e to 3e5cade Compare June 6, 2023 04:42
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #3642 (3e5cade) into release-1.4 (12f8017) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           release-1.4    #3642      +/-   ##
===============================================
- Coverage        41.43%   41.40%   -0.03%     
===============================================
  Files              193      193              
  Lines            17142    17153      +11     
===============================================
  Hits              7102     7102              
- Misses            9625     9636      +11     
  Partials           415      415              
Flag Coverage Δ
unittests 41.40% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/core/generic_scheduler.go 0.00% <0.00%> (ø)
pkg/scheduler/core/util.go 64.77% <0.00%> (-5.60%) ⬇️

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@karmada-bot karmada-bot merged commit 9fc4681 into karmada-io:release-1.4 Jun 6, 2023
@chaunceyjiang chaunceyjiang deleted the automated-cherry-pick-of-#3496-origin-release-1.4 branch June 26, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants