Fix zero deployment can still propagate to member clusters when EnableEmptyWorkloadPropagation flag is false

[chaunceyjiang]

What type of PR is this?
/kind bug

What this PR does / why we need it:

Fix zero deployment can still propagate to member clusters when EnableEmptyWorkloadPropagation flag is false

Which issue(s) this PR fixes:
Fixes #3495

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-scheduler`: Fixed the issue that empty deployment can still be propagated to member clusters even when `--enableEmptyWorkloadPropagation` flag is false.

[chaunceyjiang]

EnableEmptyWorkloadPropagation is false.

[chaunceyjiang]

EnableEmptyWorkloadPropagation is true.

[XiShanYongYe-Chang]

Thanks, so quick response!
Is it convenient to add some tests to protect it?

[codecov-commenter]

Codecov Report

Merging #3496 (6dd4a71) into master (2e6962f) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3496      +/-   ##
==========================================
- Coverage   52.96%   52.94%   -0.02%     
==========================================
  Files         216      216              
  Lines       20014    20019       +5     
==========================================
- Hits        10601    10600       -1     
- Misses       8843     8848       +5     
- Partials      570      571       +1     

Flag	Coverage Δ
unittests	52.94% <66.66%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/util/helper/binding.go	70.28% <66.66%> (-1.04%)	⬇️

... and 2 files with indirect coverage changes

[chaunceyjiang]

/hold

[chaunceyjiang]

/hold cancel

[chaunceyjiang]

/cc @XiShanYongYe-Chang @Garrybest

[XiShanYongYe-Chang]

Thanks @chaunceyjiang
/lgtm

I have raise a pr to debug the failed test case, #3518

This error has nothing to do with the current modification. So ask @RainbowMango to help rerun the test.
/cc @RainbowMango

[chaunceyjiang]

/cc @XiShanYongYe-Chang @Garrybest Please take a look.

[Garrybest]

Thanks!
/lgtm

[chaunceyjiang]

/cc @RainbowMango @XiShanYongYe-Chang

[RainbowMango]

Do you think this patch should be included in v1.6(which will be cut today)?

[chaunceyjiang]

Do you think this patch should be included in v1.6(which will be cut today)?

Yes, i think it is necessar, otherwise, a lot of 'empty shell' in member clusters.

[RainbowMango]

/assign

[RainbowMango]

/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[XiShanYongYe-Chang]

Hi @chaunceyjiang I think we need to cherry-pick this patch to the previous branch, how do you think?

[chaunceyjiang]

OK