Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3777: chart: fix karmada search external etcd no volume mount #3784

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Jul 11, 2023

Cherry pick of #3777 on release-1.6.
#3777: chart: fix karmada search external etcd no volume mount
For details on the cherry pick process, see the cherry pick requests page.

Chart: Fixed the issue that `karmada-search` no ETCD secret volume mount when using external ETCD.

Signed-off-by: xin.li <xin.li@daocloud.io>
@karmada-bot karmada-bot requested review from pidb and Poor12 July 11, 2023 14:41
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3784 (1479cb8) into release-1.6 (fdc7ac6) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           release-1.6    #3784      +/-   ##
===============================================
- Coverage        55.21%   55.19%   -0.02%     
===============================================
  Files              221      221              
  Lines            20834    20834              
===============================================
- Hits             11503    11499       -4     
- Misses            8719     8723       +4     
  Partials           612      612              
Flag Coverage Δ
unittests 55.19% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@Poor12
Copy link
Member

Poor12 commented Jul 12, 2023

LGTM
Please add the release note.

@my-git9
Copy link
Member Author

my-git9 commented Jul 12, 2023

LGTM Please add the release note.

Updated, thanks

@Poor12
Copy link
Member

Poor12 commented Jul 12, 2023

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Poor12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@karmada-bot karmada-bot merged commit 8e04d55 into karmada-io:release-1.6 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants