-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kubernetes compatibility #3786
Conversation
Hi, can you help update |
f2355fd
to
856966e
Compare
updated,thx |
Can you help run the compatibility testing workflow in your forked repository and see if everything is okay? To manually trigger and run the workflow, you can modify Other lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to add a test against Kubernetes v1.27.
What we need to do is add the new version to the matrix of CI, something like:
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 79ed2141..c2a69b75 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -112,7 +112,7 @@ jobs:
# Here support the latest three minor releases of Kubernetes, this can be considered to be roughly
# the same as the End of Life of the Kubernetes release: https://kubernetes.io/releases/
# Please remember to update the CI Schedule Workflow when we add a new version.
- k8s: [ v1.24.2, v1.25.0, v1.26.0 ]
+ k8s: [ v1.25.0, v1.26.0, v1.27.3]
steps:
- name: checkout code
uses: actions/checkout@v3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to updated the schedule workflow, something like:
diff --git a/.github/workflows/ci-schedule-compatibility.yaml b/.github/workflows/ci-schedule-compatibility.yaml
index d9f19fdd..486fecff 100644
--- a/.github/workflows/ci-schedule-compatibility.yaml
+++ b/.github/workflows/ci-schedule-compatibility.yaml
@@ -12,19 +12,19 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
- kubeapiserver-version: [ v1.21.10, v1.22.7, v1.23.4, v1.24.2, v1.25.0, v1.26.0 ]
- karmada-version: [ release-1.3, release-1.4, release-1.5 ]
+ kubeapiserver-version: [ v1.21.10, v1.22.7, v1.23.4, v1.24.2, v1.25.0, v1.26.0, v1.27.3]
+ karmada-version: [ release-1.4, release-1.5, release-1.6 ]
include:
- - karmada-version: release-1.3
- go-version: 1.18.3
-
- karmada-version: release-1.4
go-version: 1.19.5
- karmada-version: release-1.5
go-version: 1.19.5
+ - karmada-version: release-1.6
+ go-version: 1.20.4
+
steps:
- name: checkout code
uses: actions/checkout@v3
diff --git a/.github/workflows/ci-schedule.yml b/.github/workflows/ci-schedule.yml
index dd820d0a..44b9a055 100644
--- a/.github/workflows/ci-schedule.yml
+++ b/.github/workflows/ci-schedule.yml
@@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
- k8s: [ v1.21.10, v1.22.7, v1.23.4, v1.24.2, v1.25.0, v1.26.0 ]
+ k8s: [ v1.21.10, v1.22.7, v1.23.4, v1.24.2, v1.25.0, v1.26.0, v1.27.3 ]
steps:
- name: checkout code
uses: actions/checkout@v3
Signed-off-by: xin.li <xin.li@daocloud.io>
856966e
to
2b00c76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update Kubernetes compatibility
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: