Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes compatibility #3786

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Jul 11, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Update Kubernetes compatibility

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 11, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 11, 2023
@jwcesign
Copy link
Member

Hi, can you help update .github/workflows/ci-schedule-compatibility.yaml to test the compatibility?

@my-git9
Copy link
Member Author

my-git9 commented Jul 12, 2023

Hi, can you help update .github/workflows/ci-schedule-compatibility.yaml to test the compatibility?

updated,thx

@jwcesign
Copy link
Member

jwcesign commented Jul 13, 2023

Can you help run the compatibility testing workflow in your forked repository and see if everything is okay?

To manually trigger and run the workflow, you can modify .github/workflows/ci-schedule-compatibility.yaml.

Other lgtm

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to add a test against Kubernetes v1.27.
What we need to do is add the new version to the matrix of CI, something like:

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 79ed2141..c2a69b75 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -112,7 +112,7 @@ jobs:
         # Here support the latest three minor releases of Kubernetes, this can be considered to be roughly
         # the same as the End of Life of the Kubernetes release: https://kubernetes.io/releases/
         # Please remember to update the CI Schedule Workflow when we add a new version.
-        k8s: [ v1.24.2, v1.25.0, v1.26.0 ]
+        k8s: [ v1.25.0, v1.26.0, v1.27.3]
     steps:
       - name: checkout code
         uses: actions/checkout@v3

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to updated the schedule workflow, something like:

diff --git a/.github/workflows/ci-schedule-compatibility.yaml b/.github/workflows/ci-schedule-compatibility.yaml
index d9f19fdd..486fecff 100644
--- a/.github/workflows/ci-schedule-compatibility.yaml
+++ b/.github/workflows/ci-schedule-compatibility.yaml
@@ -12,19 +12,19 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        kubeapiserver-version: [ v1.21.10, v1.22.7, v1.23.4, v1.24.2, v1.25.0, v1.26.0 ]
-        karmada-version: [ release-1.3, release-1.4, release-1.5 ]
+        kubeapiserver-version: [ v1.21.10, v1.22.7, v1.23.4, v1.24.2, v1.25.0, v1.26.0, v1.27.3]
+        karmada-version: [ release-1.4, release-1.5, release-1.6 ]

         include:
-        - karmada-version: release-1.3
-          go-version: 1.18.3
-
         - karmada-version: release-1.4
           go-version: 1.19.5

         - karmada-version: release-1.5
           go-version: 1.19.5

+        - karmada-version: release-1.6
+          go-version: 1.20.4
+
     steps:
       - name: checkout code
         uses: actions/checkout@v3
diff --git a/.github/workflows/ci-schedule.yml b/.github/workflows/ci-schedule.yml
index dd820d0a..44b9a055 100644
--- a/.github/workflows/ci-schedule.yml
+++ b/.github/workflows/ci-schedule.yml
@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        k8s: [ v1.21.10, v1.22.7, v1.23.4, v1.24.2, v1.25.0, v1.26.0 ]
+        k8s: [ v1.21.10, v1.22.7, v1.23.4, v1.24.2, v1.25.0, v1.26.0, v1.27.3 ]
     steps:
       - name: checkout code
         uses: actions/checkout@v3

Signed-off-by: xin.li <xin.li@daocloud.io>
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 13, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@karmada-bot karmada-bot merged commit 2d22b74 into karmada-io:master Jul 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants