Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] update k8s compatibility for CI of cli #3938

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Aug 14, 2023

What type of PR is this?

/kind cleanup

update k8s compatibility for CI of cli to v1.25.0,v1.26.0,v1.27.3

What this PR does / why we need it:

The PR #3786 lose the part of cli.

The PR #3913 lose the part of cli.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update k8s compatibility to v1.25.0,v1.26.0,v1.27.3

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 14, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2023
Signed-off-by: Lan Liang <gcslyp@gmail.com>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @liangyuanpeng, please remember to update the CI Schedule Workflow when we add a new version.

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Aug 14, 2023

@XiShanYongYe-Chang There are update in the PR #3786 , This PR is to update the content of the CLI synchronously. This PR have not add a new version for CI.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... Thanks for reminding me.
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@@ -31,7 +31,7 @@ jobs:
go-version: 1.20.6
- uses: engineerd/setup-kind@v0.5.0
with:
version: "v0.17.0"
version: "v0.20.0"
Copy link
Contributor Author

@liangyuanpeng liangyuanpeng Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm plan to update this part to Makefile or hack/shell for reduce fragmentation. Today, This action only using with CLI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean get rid of this engineerd/setup-kind? And install kind by Makefile or shell?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed it during #3913.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@karmada-bot karmada-bot merged commit 25db1e0 into karmada-io:master Aug 14, 2023
12 checks passed
@liangyuanpeng liangyuanpeng deleted the update_ci_k8sversion branch August 15, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants