-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] update k8s compatibility for CI of cli #3938
[CI] update k8s compatibility for CI of cli #3938
Conversation
Signed-off-by: Lan Liang <gcslyp@gmail.com>
c39585f
to
d4eeb9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @liangyuanpeng, please remember to update the CI Schedule Workflow when we add a new version.
@XiShanYongYe-Chang There are update in the PR #3786 , This PR is to update the content of the CLI synchronously. This PR have not add a new version for CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... Thanks for reminding me.
/lgtm
@@ -31,7 +31,7 @@ jobs: | |||
go-version: 1.20.6 | |||
- uses: engineerd/setup-kind@v0.5.0 | |||
with: | |||
version: "v0.17.0" | |||
version: "v0.20.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm plan to update this part to Makefile or hack/shell for reduce fragmentation. Today, This action only using with CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean get rid of this engineerd/setup-kind
? And install kind by Makefile or shell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed it during #3913.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
update k8s compatibility for CI of cli to v1.25.0,v1.26.0,v1.27.3
What this PR does / why we need it:
The PR #3786 lose the part of cli.
The PR #3913 lose the part of cli.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: