Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded alpine base image #3942

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

Rajan-226
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #3936

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The base image `alpine` now has been promoted from `alpine:3.18.2` to `alpine:3.18.3`.

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 14, 2023
@karmada-bot
Copy link
Collaborator

Welcome @Rajan-226! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2023
@RainbowMango
Copy link
Member

Thanks @Rajan-226 , looks all good. You might need to sign the commit as per:
https://github.com/karmada-io/karmada/pull/3942/checks?check_run_id=15886826982.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #3942 (f496308) into master (25db1e0) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3942      +/-   ##
==========================================
- Coverage   54.71%   54.69%   -0.02%     
==========================================
  Files         229      229              
  Lines       22074    22074              
==========================================
- Hits        12077    12074       -3     
- Misses       9351     9354       +3     
  Partials      646      646              
Flag Coverage Δ
unittests 54.69% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Signed-off-by: rajan.sharma <rajan.sharma@razorpay.com>
@Rajan-226
Copy link
Contributor Author

@RainbowMango Done

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @Rajan-226 and welcome to Karmada~

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@karmada-bot karmada-bot merged commit b134d68 into karmada-io:master Aug 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update alpine base image to address vulnerabilities
4 participants